build/8184: Missing quotes around $(INSTDIR) in makefile.win

[Jack Tan <ja...@yahoo.com>]

>Number:         8184
>Category:       build
>Synopsis:       Missing quotes around $(INSTDIR) in makefile.win
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Tue Aug 14 12:30:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     jack_s_tan@yahoo.com
>Release:        1.3.20
>Organization:
apache
>Environment:
Windows 2000 SP2
Microsoft Visual C++ 6.0 SP5
Compiling from command line using NMAKE
>Description:
I am building and installing Apache on Windows from the command line using NMAKE (not the IDE).  The current directory is src/.  I have successfully built Apache using "nmake /f Makefile.win _apacher" and am trying to execute

nmake /f Makefile.win installr INSTDIR="E:\Program Files\Apache Group\Apache"

The build fails on the following line in the makefile:

awk -f <<script2.awk "support\apxs.pl" $(INSTDIR) >"$(INSTDIR)\bin\apxs.pl"

The failure occurs because $(INSTDIR) contains embedded spaces, but the macro preceding the redirection is not quoted.  By adding quotation marks, the build finishes successfully:

awk -f <<script2.awk "support\apxs.pl" "$(INSTDIR)" >"$(INSTDIR)\bin\apxs.pl"
>How-To-Repeat:
Build from the command line and install into a directory that contains embedded spaces.
>Fix:
Yes.  Add quotation marks around the $(INSTDIR) macro on the following line in src/makefile.win:

Bad:  awk -f <<script2.awk "support\apxs.pl" $(INSTDIR) >"$(INSTDIR)\bin\apxs.pl"

Fix:  awk -f <<script2.awk "support\apxs.pl" "$(INSTDIR)" >"$(INSTDIR)\bin\apxs.pl"
>Release-Note:
>Audit-Trail:
>Unformatted:
 [In order for any reply to be added to the PR database, you need]
 [to include <ap...@Apache.Org> in the Cc line and make sure the]
 [subject line starts with the report component and number, with ]
 [or without any 'Re:' prefixes (such as "general/1098:" or      ]
 ["Re: general/1098:").  If the subject doesn't match this       ]
 [pattern, your message will be misfiled and ignored.  The       ]
 ["apbugs" address is not added to the Cc line of messages from  ]
 [the database automatically because of the potential for mail   ]
 [loops.  If you do not include this Cc, your reply may be ig-   ]
 [nored unless you are responding to an explicit request from a  ]
 [developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]