You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:00:40 UTC
[GitHub] [arrow-datafusion] edrevo opened a new pull request #589: Move ballista standalone mode to client
edrevo opened a new pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #588.
# What changes are included in this PR?
- Standalone feature in client lib
- Removed --local param in executor
# Are there any user-facing changes?
Yes, the executor no longer has a --local mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
edrevo commented on pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#issuecomment-865119490
Build failure seems like a Cargo issue. I've opened https://github.com/rust-lang/cargo/issues/9608. Let's see if they confirm it is a bug or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on a change in pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
edrevo commented on a change in pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#discussion_r656028126
##########
File path: dev/docker/ballista-base.dockerfile
##########
@@ -23,7 +23,7 @@
# Base image extends debian:buster-slim
-FROM rust:1.51.0-buster AS builder
+FROM rust:1.52.1-buster AS builder
Review comment:
i have 2 more PRs open. i'll change it in one of the other ones, if that's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
edrevo commented on pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#issuecomment-865119490
Build failure seems like a Cargo issue. I've opened https://github.com/rust-lang/cargo/issues/9608. Let's see if they confirm it is a bug or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
edrevo commented on pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#issuecomment-865784447
@andygrove, this one should be ready for merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] edrevo commented on pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
edrevo commented on pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#issuecomment-864207299
cc @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#discussion_r654865677
##########
File path: dev/docker/ballista-base.dockerfile
##########
@@ -23,7 +23,7 @@
# Base image extends debian:buster-slim
-FROM rust:1.51.0-buster AS builder
+FROM rust:1.52.1-buster AS builder
Review comment:
1.53 is out now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #589: Move ballista standalone mode to client
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #589:
URL: https://github.com/apache/arrow-datafusion/pull/589#issuecomment-864216485
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#589](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (697dd15) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/51e5445fa51cef4f72df5db7804906a729fc5aa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51e5445) will **increase** coverage by `0.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 76.02% 76.08% +0.06%
==========================================
Files 156 158 +2
Lines 27063 27115 +52
==========================================
+ Hits 20575 20631 +56
+ Misses 6488 6484 -4
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ballista/rust/client/src/columnar\_batch.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9jbGllbnQvc3JjL2NvbHVtbmFyX2JhdGNoLnJz) | `0.00% <ø> (ø)` | |
| [ballista/rust/client/src/context.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9jbGllbnQvc3JjL2NvbnRleHQucnM=) | `0.00% <0.00%> (ø)` | |
| [ballista/rust/executor/src/execution\_loop.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9leGVjdXRvci9zcmMvZXhlY3V0aW9uX2xvb3AucnM=) | `0.00% <ø> (ø)` | |
| [ballista/rust/executor/src/main.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9leGVjdXRvci9zcmMvbWFpbi5ycw==) | `0.00% <0.00%> (ø)` | |
| [ballista/rust/executor/src/standalone.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9leGVjdXRvci9zcmMvc3RhbmRhbG9uZS5ycw==) | `0.00% <0.00%> (ø)` | |
| [ballista/rust/scheduler/src/lib.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9zY2hlZHVsZXIvc3JjL2xpYi5ycw==) | `20.81% <ø> (ø)` | |
| [ballista/rust/scheduler/src/standalone.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9zY2hlZHVsZXIvc3JjL3N0YW5kYWxvbmUucnM=) | `0.00% <0.00%> (ø)` | |
| [benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVuY2htYXJrcy9zcmMvYmluL3RwY2gucnM=) | `30.98% <0.00%> (+0.14%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/arrow-datafusion/pull/589/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [51e5445...697dd15](https://codecov.io/gh/apache/arrow-datafusion/pull/589?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org