You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/23 19:23:27 UTC
[GitHub] [fineract-cn-mobile] varsvat commented on a change in pull request #171: Fix-305: Checkbox replaced with Icons for proportionality field in Edit payroll Screen
varsvat commented on a change in pull request #171:
URL: https://github.com/apache/fineract-cn-mobile/pull/171#discussion_r599866951
##########
File path: app/src/main/java/org/apache/fineract/ui/adapters/PayrollAllocationAdapter.kt
##########
@@ -28,7 +29,13 @@ class PayrollAllocationAdapter @Inject constructor()
val (accountNumber, amount, proportional) = payrollAllocation[position]
holder.tvAccount.text = accountNumber
holder.tvAmount.text = amount.toString()
- holder.cbProportional.isChecked = proportional
+ if (proportional) {
+ holder.ivproportional_checked.visibility = View.VISIBLE
+ holder.ivproportional_crossed.visibility= View.GONE
+ }else {
Review comment:
What is this , I dont kno about this. Why is it failing ?
##########
File path: app/src/main/java/org/apache/fineract/ui/adapters/PayrollAllocationAdapter.kt
##########
@@ -28,7 +29,13 @@ class PayrollAllocationAdapter @Inject constructor()
val (accountNumber, amount, proportional) = payrollAllocation[position]
holder.tvAccount.text = accountNumber
holder.tvAmount.text = amount.toString()
- holder.cbProportional.isChecked = proportional
+ if (proportional) {
+ holder.ivproportional_checked.visibility = View.VISIBLE
+ holder.ivproportional_crossed.visibility= View.GONE
+ }else {
Review comment:
What is this , I dont kn about this. Why is it failing ?
##########
File path: app/src/main/java/org/apache/fineract/ui/adapters/PayrollAllocationAdapter.kt
##########
@@ -28,7 +29,13 @@ class PayrollAllocationAdapter @Inject constructor()
val (accountNumber, amount, proportional) = payrollAllocation[position]
holder.tvAccount.text = accountNumber
holder.tvAmount.text = amount.toString()
- holder.cbProportional.isChecked = proportional
+ if (proportional) {
+ holder.ivproportional_checked.visibility = View.VISIBLE
+ holder.ivproportional_crossed.visibility= View.GONE
+ }else {
Review comment:
What is this , I dont knew about this. Why is it failing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org