You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjinleekr <gi...@git.apache.org> on 2018/09/05 13:17:37 UTC
[GitHub] spark pull request #22342: Feature/fix kafka sql trivials
GitHub user dongjinleekr opened a pull request:
https://github.com/apache/spark/pull/22342
Feature/fix kafka sql trivials
## What changes were proposed in this pull request?
Fix unused imports & outdated comments on `kafka-0-10-sql` module. (Found while I was working on [SPARK-23539](https://github.com/apache/spark/pull/22282))
## How was this patch tested?
Existing unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjinleekr/spark feature/fix-kafka-sql-trivials
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22342
----
commit 4a5a7e8c88a53f363b58dada46fe9df13a814c0f
Author: Lee Dongjin <do...@...>
Date: 2018-09-05T13:02:44Z
Remove unused import from KafkaRelation
commit 3b9ea74bc5facf7a17f698bbaac6f08243fc11bc
Author: Lee Dongjin <do...@...>
Date: 2018-09-05T13:05:15Z
Remove unused import from KafkaOffsetRangeCalculator
commit f116d9e7bb4de94510f67677f92b726f678d2bcc
Author: Lee Dongjin <do...@...>
Date: 2018-09-05T13:13:38Z
Fix comments on KafkaStreamWriterFactory: it does not extend DataWriterFactory from commit e754887.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22342
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22342
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22342
**[Test build #95717 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95717/testReport)** for PR 22342 at commit [`f116d9e`](https://github.com/apache/spark/commit/f116d9e7bb4de94510f67677f92b726f678d2bcc).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22342
Merged to master/2.4
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22342
**[Test build #95719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95719/testReport)** for PR 22342 at commit [`ee4e97a`](https://github.com/apache/spark/commit/ee4e97a8187c236ccf52f1c882b607a9421d284e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22342
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22342
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22342
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95719/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22342
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: Feature/fix kafka sql trivials
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22342
**[Test build #95717 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95717/testReport)** for PR 22342 at commit [`f116d9e`](https://github.com/apache/spark/commit/f116d9e7bb4de94510f67677f92b726f678d2bcc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22342
It's fine. We usually don't do little minor cleanup PRs but it's reasonable for a new contributor to get warmed up like this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22342
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95717/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22342: [MINOR][SS] Fix kafka-0-10-sql trivials
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22342
**[Test build #95719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95719/testReport)** for PR 22342 at commit [`ee4e97a`](https://github.com/apache/spark/commit/ee4e97a8187c236ccf52f1c882b607a9421d284e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org