You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/02/09 05:56:54 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

junichi11 opened a new pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578


   - https://issues.apache.org/jira/browse/NETBEANS-6438
   - Add code folding for attributes
   
   #### Screenshots
   ##### Expand
   
   ![nb-6438-folding-attributes](https://user-images.githubusercontent.com/738383/153130528-ef8a84b7-fd10-46f9-8432-920c1ed6ce18.png)
   
   ##### Collapse
   ![nb-6438-folding-attributes-collapse](https://user-images.githubusercontent.com/738383/153130542-5ce09173-2e0d-44b6-9874-9f3151e3b5b2.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578#issuecomment-1034793662


   @tmysik Thank you for your review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578#issuecomment-1034434507


   @tmysik Could you please have a look at this? If there is no problem, let's merge it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578#discussion_r803564035



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/csl/PHPFoldingProvider.java
##########
@@ -31,7 +31,8 @@
  */
 @MimeRegistration(mimeType = FileUtils.PHP_MIME_TYPE, service = FoldTypeProvider.class, position = 1000)
 public class PHPFoldingProvider implements FoldTypeProvider {
-    private static final Collection<FoldType> TYPES = new ArrayList<>(8);
+
+    private static final Collection<FoldType> TYPES = new ArrayList<>(9);

Review comment:
       I also think so :) I'll fix it next time. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578#discussion_r803425127



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/csl/PHPFoldingProvider.java
##########
@@ -31,7 +31,8 @@
  */
 @MimeRegistration(mimeType = FileUtils.PHP_MIME_TYPE, service = FoldTypeProvider.class, position = 1000)
 public class PHPFoldingProvider implements FoldTypeProvider {
-    private static final Collection<FoldType> TYPES = new ArrayList<>(8);
+
+    private static final Collection<FoldType> TYPES = new ArrayList<>(9);

Review comment:
       Just a nitpick




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578#discussion_r803424497



##########
File path: php/php.editor/src/org/netbeans/modules/php/editor/csl/PHPFoldingProvider.java
##########
@@ -31,7 +31,8 @@
  */
 @MimeRegistration(mimeType = FileUtils.PHP_MIME_TYPE, service = FoldTypeProvider.class, position = 1000)
 public class PHPFoldingProvider implements FoldTypeProvider {
-    private static final Collection<FoldType> TYPES = new ArrayList<>(8);
+
+    private static final Collection<FoldType> TYPES = new ArrayList<>(9);

Review comment:
       Perhaps `Arrays.asList()`?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #3578: [NETBEANS-6438] Add code folding for PHP attributes

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #3578:
URL: https://github.com/apache/netbeans/pull/3578


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists