[GitHub] alficles commented on a change in pull request #2395: To go ds sslkeys generate

[GitBox <gi...@apache.org>]

alficles commented on a change in pull request #2395: To go ds sslkeys generate
URL: https://github.com/apache/incubator-trafficcontrol/pull/2395#discussion_r194776585
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/deliveryservice/gencert.go
 ##########
 @@ -0,0 +1,121 @@
+package deliveryservice
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+	"bytes"
+	"crypto/rand"
+	"crypto/rsa"
+	"crypto/x509"
+	"crypto/x509/pkix"
+	"encoding/base64"
+	"encoding/pem"
+	"errors"
+	"math/big"
+	"time"
+
+	"github.com/apache/incubator-trafficcontrol/lib/go-util"
+)
+
+const NewCertValidDuration = time.Hour * 24 * 365
+
+// GenerateCert generates a key and certificate for serving HTTPS. The generated key is 2048-bit RSA, to match the old Perl code.
+// The certificate will be valid for NewCertValidDuration time after now.
+// Returns PEM-encoded certificate signing request (csr), certificate (crt), and key; or any error.
+func GenerateCert(host, country, city, state, org, unit string) ([]byte, []byte, []byte, error) {
 
 Review comment:
   I see the comment that describes the return, but named returns would help readability here, I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services