[jira] [Commented] (OFBIZ-7113) Refactoring permission model call

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051592#comment-17051592 ] 

ASF subversion and git services commented on OFBIZ-7113:
--------------------------------------------------------

Commit 9a50fa907b041df6907a15d6742a5527fcbf610d in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9a50fa9 ]

Fixed: Refactoring permission model call, alone permission service failed
(OFBIZ-11440)

During refactoring (OFBIZ-7113), the service reader used two different methods to read a
permission service definition if is present alone or in a group. For the alone version a link
was missing between the service and the permission service to resolve correctly the permission.

To solve this problem I reorganized to use only one method to initialize a service model permission.

Other point, an attribute renaming was missed : action -> permissionMainAction, when service permission call was called

Last, these problems weren't detected before due to missing unit test on failure service permission, now cover.


> Refactoring permission model call
> ---------------------------------
>
>                 Key: OFBIZ-7113
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7113
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-7113.patch, OFBIZ-7113.patch, OFBIZ-7113.patch
>
>
> With the subject on mailing list "Permission service not on the same transaction" : http://markmail.org/message/34vxi4ntmbj7vzcr
> I started the improvement but the java code need to be clean and refactoring. 
> I share my first draft patch, but need more works. I realize :
>  * unified call evalPermission
>  * move all related field for permission service on ModelService to ModelPermission
>  * Remove  deprecated code
>  * start labelized error message  
>  * add new attributes on permission model : required-new-transaction and return-error-on-failure



--
This message was sent by Atlassian Jira
(v8.3.4#803005)