You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/16 08:52:46 UTC

[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1451: IGNITE-18413 Reorganize metastorage modules

sashapolo commented on code in PR #1451:
URL: https://github.com/apache/ignite-3/pull/1451#discussion_r1050503591


##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -0,0 +1,125 @@
+/*

Review Comment:
   I agree with you, however this is how it was implemented before my changes, I simply extracted an interface. I don't want to rename this in my PR in order to reduce the amount of changes.



##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/dsl/OperationType.java:
##########
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-package org.apache.ignite.internal.metastorage.common;
+package org.apache.ignite.internal.metastorage.dsl;

Review Comment:
   Sure, do you have a better name in mind?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org