You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/21 16:45:41 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #2841: [Improve][Connector-V2] Improve read parquet
TyrantLucifer opened a new pull request, #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
close #2714
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977138423
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
<artifactId>flink-shaded-hadoop-2</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <!-- base module need skip shading -->
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+ <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>
Review Comment:
Use the prefix `${seatunnel.shade.package}.connector.file.hadoop.org.apache.avro`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977394004
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
<artifactId>flink-shaded-hadoop-2</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <!-- base module need skip shading -->
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+ <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>
Review Comment:
Use the prefix ${seatunnel.shade.package}.${connector}.org.apache.avro?
reference
https://github.com/apache/flink/blob/master/flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml#L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977135470
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
<artifactId>flink-shaded-hadoop-2</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <!-- base module need skip shading -->
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+ <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>
Review Comment:
Will `${seatunnel.shade.package}.org.apache.avro` conflict with other connector shade class name?
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetReadStrategyTest.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.file.writer;
+
+import org.apache.seatunnel.api.source.Collector;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.connectors.seatunnel.file.source.reader.ParquetReadStrategy;
+
+import org.junit.jupiter.api.Test;
+
+import java.net.URL;
+import java.nio.file.Paths;
+
+public class ParquetReadStrategyTest {
+ @Test
+ public void testParquetRead() throws Exception {
+ URL resource = ParquetReadStrategyTest.class.getResource("/test.parquet");
Review Comment:
Use ParquetWriteStrategy to create new files and write data, then use ParquetReadStrategy to read data for check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#issuecomment-1255729237
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
hailin0 commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977394004
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
<artifactId>flink-shaded-hadoop-2</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <!-- base module need skip shading -->
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+ <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>
Review Comment:
Use the prefix `${seatunnel.shade.package}.${connector}.org.apache.avro`?
reference
https://github.com/apache/flink/blob/master/flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml#L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977282735
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/file/writer/ParquetReadStrategyTest.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.file.writer;
+
+import org.apache.seatunnel.api.source.Collector;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.connectors.seatunnel.file.source.reader.ParquetReadStrategy;
+
+import org.junit.jupiter.api.Test;
+
+import java.net.URL;
+import java.nio.file.Paths;
+
+public class ParquetReadStrategyTest {
+ @Test
+ public void testParquetRead() throws Exception {
+ URL resource = ParquetReadStrategyTest.class.getResource("/test.parquet");
Review Comment:
ParquetWriteStrategy has not been developed completed, in order not to delay to read this aspect of the test we can fill in this part next pr, what do you think about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977276478
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
<artifactId>flink-shaded-hadoop-2</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <!-- base module need skip shading -->
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+ <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>
Review Comment:
> Will `${seatunnel.shade.package}.org.apache.avro` conflict with other connector shade class name?
Yes, it will conflict with spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2841: [Improve][Connector-V2] Improve read parquet
Posted by GitBox <gi...@apache.org>.
TyrantLucifer commented on code in PR #2841:
URL: https://github.com/apache/incubator-seatunnel/pull/2841#discussion_r977398516
##########
seatunnel-connectors-v2/connector-file/connector-file-hadoop/pom.xml:
##########
@@ -40,4 +40,44 @@
<artifactId>flink-shaded-hadoop-2</artifactId>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <!-- base module need skip shading -->
+ <configuration>
+ <relocations>
+ <relocation>
+ <pattern>org.apache.avro</pattern>
+ <shadedPattern>${seatunnel.shade.package}.org.apache.avro</shadedPattern>
Review Comment:
I'll change it when I'm free in the evening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org