You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/03/11 12:20:42 UTC
[GitHub] [submarine] kevin85421 opened a new pull request #221:
SUBMARINE-423. Update the E2E test document
kevin85421 opened a new pull request #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221
### What is this PR for?
Update the E2E test document
### What type of PR is it?
[Improvement]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-423#
### How should this be tested?
https://travis-ci.org/github/kevin85421/hadoop-submarine?utm_medium=notification&utm_source=github_status
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need an update? No
* Are there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #221:
SUBMARINE-423. Update the E2E test document
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221#discussion_r390981493
##########
File path: docs/development/IntegrationTest.md
##########
@@ -12,17 +12,13 @@
limitations under the License. See accompanying LICENSE file.
-->
-# IntegrationTest
+# Integration Test
+## Introduction
+1. Now, Apache Submarine supports two kinds of integration tests, `test-e2e` and `test-k8s`, and these two modules can be found in the [submarine/submarine-test](https://github.com/apache/submarine/tree/master/submarine-test) directory.
Review comment:
@yuanzac Thank you for your review. I have fixed the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #221:
SUBMARINE-423. Update the E2E test document
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221#discussion_r390954315
##########
File path: docs/development/IntegrationTest.md
##########
@@ -12,17 +12,13 @@
limitations under the License. See accompanying LICENSE file.
-->
-# IntegrationTest
+# Integration Test
+## Introduction
+1. Now, Apache Submarine supports two kinds of integration tests, `test-e2e` and `test-k8s`, and these two modules can be found in the [submarine/submarine-test](https://github.com/apache/submarine/tree/master/submarine-test) directory.
-Submarine now supports two kinds of integration tests.
+2. Currently, there are some differences between `test-e2e` and `test-k8s` in operation mode. To elaborate, `test-e2e` needs to deploy Apache Submarine locally, while `test-k8s` deploys Apache Submarine via k8s.
-They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
-
-There are currently some differences between `test-e2e` and `test-k8s` in operation mode.
-
-Among them, `test-e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
-
-These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+3. These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
Review comment:
How about we change two methods to two test modules
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] yuanzac commented on a change in pull request #221:
SUBMARINE-423. Update the E2E test document
Posted by GitBox <gi...@apache.org>.
yuanzac commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221#discussion_r390951022
##########
File path: docs/development/IntegrationTest.md
##########
@@ -12,17 +12,13 @@
limitations under the License. See accompanying LICENSE file.
-->
-# IntegrationTest
+# Integration Test
+## Introduction
+1. Now, Apache Submarine supports two kinds of integration tests, `test-e2e` and `test-k8s`, and these two modules can be found in the [submarine/submarine-test](https://github.com/apache/submarine/tree/master/submarine-test) directory.
Review comment:
We'd better change ", and these two modules" to ". And these two modules"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #221: SUBMARINE-423. Update
the E2E test document
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] pingsutw commented on issue #221: SUBMARINE-423. Update
the E2E test document
Posted by GitBox <gi...@apache.org>.
pingsutw commented on issue #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221#issuecomment-597642241
Thanks @kevin85421, GitHub actions failure seems unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] kevin85421 commented on a change in pull request #221:
SUBMARINE-423. Update the E2E test document
Posted by GitBox <gi...@apache.org>.
kevin85421 commented on a change in pull request #221: SUBMARINE-423. Update the E2E test document
URL: https://github.com/apache/submarine/pull/221#discussion_r390984116
##########
File path: docs/development/IntegrationTest.md
##########
@@ -12,17 +12,13 @@
limitations under the License. See accompanying LICENSE file.
-->
-# IntegrationTest
+# Integration Test
+## Introduction
+1. Now, Apache Submarine supports two kinds of integration tests, `test-e2e` and `test-k8s`, and these two modules can be found in the [submarine/submarine-test](https://github.com/apache/submarine/tree/master/submarine-test) directory.
-Submarine now supports two kinds of integration tests.
+2. Currently, there are some differences between `test-e2e` and `test-k8s` in operation mode. To elaborate, `test-e2e` needs to deploy Apache Submarine locally, while `test-k8s` deploys Apache Submarine via k8s.
-They are in the project's `submarine/submarine-test` directory, There are two modules, `e2e` and `test-k8s`.
-
-There are currently some differences between `test-e2e` and `test-k8s` in operation mode.
-
-Among them, `test-e2e` needs to deploy submarine locally, while `test-k8s` uses k8s to deploy submarine.
-
-These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
+3. These two different test methods can be applied to different test scenarios. (In the future, these two test methods may be combined or adjusted)
Review comment:
Thank you for your review. I have changed "test methods" to "test modules".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org