You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Ben Walding (JIRA)" <ta...@jakarta.apache.org> on 2005/01/31 13:26:17 UTC
[jira] Created: (TAPESTRY-257) favicon support for Shell component
favicon support for Shell component
-----------------------------------
Key: TAPESTRY-257
URL: http://issues.apache.org/jira/browse/TAPESTRY-257
Project: Tapestry
Type: Improvement
Components: Framework
Versions: 3.0.1
Reporter: Ben Walding
It would be handy if the Shell component supported setting a favicon.
eg. same as how the stylesheet can be filled in from the Shell component -
<link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
I'd expect to be able to have
<private-asset name="favicon" resource-path="/images/favicon.ico"/>
and then
<span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Resolved: (TAPESTRY-257) favicon support for Shell component
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=all ]
Andreas Andreou resolved TAPESTRY-257.
--------------------------------------
Fix Version/s: (was: 3.0.5)
Resolution: Fixed
Changes in TAPESTRY-199 fixed this.
Using <link jwcid="@Relation" href="assetOrString" rel="shortcut icon" />
from anywhere in a page or component, results in the favicon being added
in <HEAD> of the page
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Assigned To: Andreas Andreou
> Fix For: 4.1.1
>
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Commented: (TAPESTRY-257) favicon support for Shell
component
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=comments#action_12377205 ]
Andreas Andreou commented on TAPESTRY-257:
------------------------------------------
Of course, this could render
<link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" /> (as stated)
but i've seen (for instance in this very site)
<link rel="shortcut icon" href="/jira/images/icons/favicon.ico"> (type is missing)
and also
<link rel="icon" type="image/png" href="/jira/images/icons/favicon.png"> (different type and rel)
Given those alternatives, perhaps we can take care of this in a more generic way.
Perhaps the favicon parameter should only generate:
<link rel="shortcut icon" href="/jira/images/icons/favicon.ico">
and we can have an additional parameter 'links' which will accept a List or Collection or array of a
new class, named Link or HtmlLink or HtmlRelation. This should have href, media, name, rev, rel, title, type
properties and will be able to render them if they contain a non-null value.
See http://www.blooberry.com/indexdot/html/tagpages/l/link.htm for more, but i think these are the most important
and they do cover css inclusion in a much better way than the currently supported.
Returning to the favicon issue, I also believe that the favicon parameter (ot whatever its name will be) should be an IAsset but also a simple string.
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Type: Improvement
> Components: Framework
> Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Assignee: Brian K. Wallace
> Fix For: 4.0.3, 3.0.5
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Updated: (TAPESTRY-257) favicon support for Shell component
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=all ]
Jesse Kuhnert updated TAPESTRY-257:
-----------------------------------
Fix Version/s: 4.1.1
(was: 4.1)
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Assigned To: Brian K. Wallace
> Fix For: 3.0.5, 4.1.1
>
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-257) favicon support for Shell component
Posted by "Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=all ]
Jesse Kuhnert updated TAPESTRY-257:
-----------------------------------
Fix Version: 4.1
(was: 4.0.3)
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Type: Improvement
> Components: Framework
> Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Assignee: Brian K. Wallace
> Fix For: 4.1, 3.0.5
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-257) favicon support for Shell component
Posted by "Brian K. Wallace (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=all ]
Brian K. Wallace reassigned TAPESTRY-257:
-----------------------------------------
Assign To: Brian K. Wallace
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Type: Improvement
> Components: Framework
> Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Assignee: Brian K. Wallace
> Fix For: 4.0.3, 3.0.5
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Updated: (TAPESTRY-257) favicon support for Shell component
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=all ]
Andreas Andreou updated TAPESTRY-257:
-------------------------------------
Fix Version: 4.0.3
3.0.5
Version: 4.0.2
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Type: Improvement
> Components: Framework
> Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Fix For: 4.0.3, 3.0.5
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org
[jira] Assigned: (TAPESTRY-257) favicon support for Shell component
Posted by "Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/TAPESTRY-257?page=all ]
Andreas Andreou reassigned TAPESTRY-257:
----------------------------------------
Assignee: Andreas Andreou (was: Brian K. Wallace)
> favicon support for Shell component
> -----------------------------------
>
> Key: TAPESTRY-257
> URL: http://issues.apache.org/jira/browse/TAPESTRY-257
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 3.0.1, 4.0.2
> Reporter: Ben Walding
> Assigned To: Andreas Andreou
> Fix For: 3.0.5, 4.1.1
>
>
> It would be handy if the Shell component supported setting a favicon.
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org