You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/03 11:38:07 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3352: fix: clippy
alamb opened a new pull request, #3352:
URL: https://github.com/apache/arrow-datafusion/pull/3352
# Which issue does this PR close?
NA
# Rationale for this change
Get CI on master back to green
Clippy is failing on master: https://github.com/apache/arrow-datafusion/runs/8168861104?check_suite_focus=true
```
Checking datafusion v11.0.0 (/__w/arrow-datafusion/arrow-datafusion/datafusion/core)
error: redundant pattern matching, consider using `is_err()`
--> datafusion/core/src/physical_plan/common.rs:196:20
|
196 | if let Err(_) = output.send(item).await {
| -------^^^^^^-------------------------- help: try this: `if (output.send(item).await).is_err()`
|
= note: `-D clippy::redundant-pattern-matching` implied by `-D warnings`
= note: this will change drop order of the result, as well as all temporaries
= note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
error: could not compile `datafusion` due to previous error
warning: build failed, waiting for other jobs to finish...
Error: Process completed with exit code 101.
```
This error was introduced in https://github.com/apache/arrow-datafusion/pull/3276 which I merged 🤦 ; It isn't clear to me why CI wasn't run on that PR
# What changes are included in this PR?
Do what clippy says
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3352: fix: clippy
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3352:
URL: https://github.com/apache/arrow-datafusion/pull/3352#issuecomment-1236309074
Fix was included in https://github.com/apache/arrow-datafusion/pull/3350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3352: fix: clippy
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3352:
URL: https://github.com/apache/arrow-datafusion/pull/3352#issuecomment-1236107557
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3352?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3352](https://codecov.io/gh/apache/arrow-datafusion/pull/3352?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf64c01) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/eb8c81f2ddacdc71086d98b96cdaa00233cb8749?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb8c81f) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3352 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 294 294
Lines 54155 54155
=======================================
+ Hits 46284 46285 +1
+ Misses 7871 7870 -1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3352/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `77.55% <100.00%> (ø)` | |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3352/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.44% <0.00%> (ø)` | |
| [datafusion/common/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3352/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3NjYWxhci5ycw==) | `84.65% <0.00%> (+0.06%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove closed pull request #3352: fix: clippy
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #3352: fix: clippy
URL: https://github.com/apache/arrow-datafusion/pull/3352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #3352: fix: clippy
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #3352:
URL: https://github.com/apache/arrow-datafusion/pull/3352#issuecomment-1236136912
fixed in https://github.com/apache/arrow-datafusion/commit/e26452ab374ad59effa785aae6235e741973569a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on pull request #3352: fix: clippy
Posted by GitBox <gi...@apache.org>.
xudong963 commented on PR #3352:
URL: https://github.com/apache/arrow-datafusion/pull/3352#issuecomment-1236106977
I think the issue can be closed 🤣 @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org