You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/15 19:52:21 UTC
[GitHub] [incubator-nuttx] walbon opened a new pull request #3068: lpc17xx_40xx/mbed : refresh defconfig
walbon opened a new pull request #3068:
URL: https://github.com/apache/incubator-nuttx/pull/3068
## Summary
Previously the defconfig was setting the toolchain from the buildroot, so if the user follow the steps in the documentation [1], the user will got an error from building step when it is looking for the gcc-arm-***nuttx***-eabi, instead of the default toolchain gcc-arm-***none***-eabi.
```
sh: 1: arm-nuttx-eabi-gcc: not found
ERROR: arm-nuttx-eabi-gcc failed: 127
command: arm-nuttx-eabi-gcc -MT ./myapp_main.root.Nuttx.apps.examples.myapp.o -M '-fno-builtin' '-funwind-tables' '-Wall' '-Wstrict-prototypes' '-Wshadow' '-Wundef' '-Os' '-fno-strict-aliasing' '-fomit-frame-pointer' '-fno-strength-reduce' '-mcpu=cortex-m3' '-mthumb' '-mfloat-abi=soft' '-isystem' '/root/Nuttx/nuttx/include' '-D__NuttX__' '-D__KERNEL__' '-pipe' '-I' '/root/Nuttx/apps/include' ./myapp_main.c
make[2]: *** [/root/Nuttx/apps/Application.mk:232: .depend] Error 1
make[2]: Leaving directory '/root/Nuttx/apps/examples/myapp'
make[1]: *** [Makefile:63: /root/Nuttx/apps/examples/myapp_depend] Error 2
make[1]: Leaving directory '/root/Nuttx/apps'
make: *** [tools/Makefile.unix:473: pass2dep] Error 2
```
1 - https://nuttx.apache.org/docs/latest/quickstart/install.html#toolchain
## Impact
Build fail.
## Testing
Build the project with target mbed:sh
``` ./tool/configure.sh mbed:nsh
make
...
make[1]: Entering directory '/root/Nuttx/nuttx/arch/arm/src'
make[2]: Entering directory '/root/Nuttx/nuttx/boards/arm/lpc17xx_40xx/mbed/src'
CC: lpc17_40_boot.c
CC: lpc17_40_leds.c
CC: lpc17_40_dac.c
CC: lpc17_40_appinit.c
AR (create): libboard.a lpc17_40_boot.o lpc17_40_leds.o lpc17_40_dac.o lpc17_40_appinit.o
make[2]: Leaving directory '/root/Nuttx/nuttx/boards/arm/lpc17xx_40xx/mbed/src'
LD: nuttx
make[1]: Leaving directory '/root/Nuttx/nuttx/arch/arm/src'
CP: nuttx.bin
```
I got a successful build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3068: lpc17xx_40xx/mbed : refresh defconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3068:
URL: https://github.com/apache/incubator-nuttx/pull/3068#discussion_r594827055
##########
File path: boards/arm/lpc17xx_40xx/mbed/configs/nsh/defconfig
##########
@@ -20,7 +20,7 @@ CONFIG_ARCH_CHIP="lpc17xx_40xx"
CONFIG_ARCH_CHIP_LPC1768=y
CONFIG_ARCH_CHIP_LPC17XX_40XX=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_ARMV7M_TOOLCHAIN_BUILDROOT=y
+CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL=y
Review comment:
remove CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL=y to avoid the CI fail since the default option doesn't need list in defconfig.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3068: lpc17xx_40xx/mbed : refresh defconfig
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3068:
URL: https://github.com/apache/incubator-nuttx/pull/3068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] walbon commented on a change in pull request #3068: lpc17xx_40xx/mbed : refresh defconfig
Posted by GitBox <gi...@apache.org>.
walbon commented on a change in pull request #3068:
URL: https://github.com/apache/incubator-nuttx/pull/3068#discussion_r595017963
##########
File path: boards/arm/lpc17xx_40xx/mbed/configs/nsh/defconfig
##########
@@ -20,7 +20,7 @@ CONFIG_ARCH_CHIP="lpc17xx_40xx"
CONFIG_ARCH_CHIP_LPC1768=y
CONFIG_ARCH_CHIP_LPC17XX_40XX=y
CONFIG_ARCH_STACKDUMP=y
-CONFIG_ARMV7M_TOOLCHAIN_BUILDROOT=y
+CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL=y
Review comment:
@xiaoxiang781216 ow, ok, I got it. I just change by hand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org