[GitHub] [skywalking-agent-test-tool] dengliming commented on pull request #19: Configure ports using a common configuration class instead of a hard-coded configuration

[GitBox <gi...@apache.org>]

dengliming commented on pull request #19:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/19#issuecomment-657056557


   > From codes level, it should be fine to provide config. Could you share why you need this?
   
   Thanks for quick reply. I found that these two places can share the port configuration.
   ```
           NettyServerBuilder.forAddress(LocalAddress.ANY)
                             .forPort(19876)
   ```
   org.apache.skywalking.plugin.test.mockcollector.service.GrpcAddressHttpService#doPost
    ```
   JsonArray jsonArray = new JsonArray();
           jsonArray.add(ConfigReader.getGrpcBindHost() + ":" + ConfigReader.getGrpcBindPort());
   ```
   And just a little advice. I can turn it off if it doesn't make sense. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org