You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/07/17 12:41:29 UTC

[GitHub] [thrift] OmmyZhang opened a new pull request, #2634: THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021

OmmyZhang opened a new pull request, #2634:
URL: https://github.com/apache/thrift/pull/2634

   I have tried to create pr for @Jimexist 's branch to fix pr #2632, but as there are too many changes, finally I decided to open a new pr to bump rust version and fix CI first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] OmmyZhang commented on pull request #2634: THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021 & THRIFT-5606: Wrong indent for const double

Posted by GitBox <gi...@apache.org>.
OmmyZhang commented on PR #2634:
URL: https://github.com/apache/thrift/pull/2634#issuecomment-1190112572

   @Jimexist thanks!
   
   By the way, can I disable ssl test for java and create a jira, to fix CI? (Seems there are also other problems, not sure, just want to try


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] Jimexist commented on pull request #2634: THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021 & THRIFT-5606: Wrong indent for const double

Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2634:
URL: https://github.com/apache/thrift/pull/2634#issuecomment-1203712517

   > @Jimexist thanks!
   > 
   > By the way, can I disable ssl test for java and create a jira, to fix CI? (Seems there are also other problems, not sure, just want to try
   
   looks like a plan to me!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] OmmyZhang commented on pull request #2634: [WIP] THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021 & THRIFT-5606: Wrong indent for const double

Posted by GitBox <gi...@apache.org>.
OmmyZhang commented on PR #2634:
URL: https://github.com/apache/thrift/pull/2634#issuecomment-1187028654

   for TRIFT-5606:
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
     -  please use squash when finally merging it
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] Jens-G closed pull request #2634: THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021 & THRIFT-5606: Wrong indent for const double

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2634: THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021 & THRIFT-5606: Wrong indent for const double
URL: https://github.com/apache/thrift/pull/2634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [thrift] OmmyZhang commented on pull request #2634: [WIP] THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021

Posted by GitBox <gi...@apache.org>.
OmmyZhang commented on PR #2634:
URL: https://github.com/apache/thrift/pull/2634#issuecomment-1186867831

   Now there are problems with Java. It seems that I should create a new Jira ticket.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org