You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mike Braden <mb...@utenzi.com> on 2001/03/13 17:41:15 UTC
[PATCH] fix for ApacheConfig.java paths for unix
This patch is for the ApacheConfig.java classes. It changes the static
(default) paths from
absolute paths to relative paths.
Without this fix, the paths are not configurable from the server.xml file as
intended. The conf paths
also default to / - i.e. /conf/jk/ and /conf/jserv/. When using absolute
paths, the TOMCAT_HOME is
ignored as well as any prefix that you set in server.xml.
Tested on Solaris and Windows 2000
# cvs diff -u ApacheConfig.java
Index: ApacheConfig.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/modules/config/Ap
acheConfig.java,v
retrieving revision 1.7
diff -u -r1.7 ApacheConfig.java
--- ApacheConfig.java 2001/03/05 02:56:49 1.7
+++ ApacheConfig.java 2001/03/13 16:32:59
@@ -118,13 +118,13 @@
// XXX maybe conf/
/** default path to JServ .conf location */
- public static final String
APACHE_CONFIG="/conf/jserv/tomcat-apache.conf";
+ public static final String
APACHE_CONFIG="conf/jserv/tomcat-apache.conf";
/** default path to mod_jk .conf location */
- public static final String MOD_JK_CONFIG = "/conf/jk/mod_jk.conf";
+ public static final String MOD_JK_CONFIG = "conf/jk/mod_jk.conf";
/** default path to workers.properties file */
- public static final String WORKERS_CONFIG =
"/conf/jk/workers.properties";
+ public static final String WORKERS_CONFIG =
"conf/jk/workers.properties";
/** default mod_jk log file location */
- public static final String JK_LOG_LOCATION = "/logs/mod_jk.log";
+ public static final String JK_LOG_LOCATION = "logs/mod_jk.log";
/** default location of mod_jserv Apache plug-in. */
public static final String MOD_JSERV;
/** default location of mod_jk Apache plug-in. */
--
Mike Braden
mbraden@utenzi.com
mikeb@mwbinc.com
Re: [PATCH] fix for ApacheConfig.java paths for unix
Posted by Mel Martinez <me...@yahoo.com>.
Mike,
Thanks for catching this. I tested assigning the path
attributes, but forgot to test the defaults on the
unix case. I'll try to get your patch tested and
applied by the end of tomorrow. I've been a little
side-tracked the last few days teaching client
personnel.
Mel
--- Mike Braden <mb...@utenzi.com> wrote:
> This patch is for the ApacheConfig.java classes. It
> changes the static
> (default) paths from
> absolute paths to relative paths.
>
> Without this fix, the paths are not configurable
> from the server.xml file as
> intended. The conf paths
> also default to / - i.e. /conf/jk/ and /conf/jserv/.
> When using absolute
> paths, the TOMCAT_HOME is
> ignored as well as any prefix that you set in
> server.xml.
>
> Tested on Solaris and Windows 2000
>
> # cvs diff -u ApacheConfig.java
>
> Index: ApacheConfig.java
>
===================================================================
> RCS file:
>
/home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/modules/config/Ap
> acheConfig.java,v
> retrieving revision 1.7
> diff -u -r1.7 ApacheConfig.java
> --- ApacheConfig.java 2001/03/05 02:56:49 1.7
> +++ ApacheConfig.java 2001/03/13 16:32:59
> @@ -118,13 +118,13 @@
> // XXX maybe conf/
>
> /** default path to JServ .conf location */
> - public static final String
> APACHE_CONFIG="/conf/jserv/tomcat-apache.conf";
> + public static final String
> APACHE_CONFIG="conf/jserv/tomcat-apache.conf";
> /** default path to mod_jk .conf location */
> - public static final String MOD_JK_CONFIG =
> "/conf/jk/mod_jk.conf";
> + public static final String MOD_JK_CONFIG =
> "conf/jk/mod_jk.conf";
> /** default path to workers.properties file */
> - public static final String WORKERS_CONFIG =
> "/conf/jk/workers.properties";
> + public static final String WORKERS_CONFIG =
> "conf/jk/workers.properties";
> /** default mod_jk log file location */
> - public static final String JK_LOG_LOCATION =
> "/logs/mod_jk.log";
> + public static final String JK_LOG_LOCATION =
> "logs/mod_jk.log";
> /** default location of mod_jserv Apache
> plug-in. */
> public static final String MOD_JSERV;
> /** default location of mod_jk Apache plug-in.
> */
>
> --
> Mike Braden
> mbraden@utenzi.com
> mikeb@mwbinc.com
>
>
>
> ATTACHMENT part 2 application/octet-stream
name=ApacheConfig.patch
>
---------------------------------------------------------------------
> To unsubscribe, e-mail:
> tomcat-dev-unsubscribe@jakarta.apache.org
> For additional commands, email:
tomcat-dev-help@jakarta.apache.org
__________________________________________________
Do You Yahoo!?
Yahoo! Auctions - Buy the things you want at great prices.
http://auctions.yahoo.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, email: tomcat-dev-help@jakarta.apache.org