[GitHub] [arrow] pitrou commented on a change in pull request #12661: ARROW-14960: [C++] Add exception to Arrow style guide based on changes in Google style guide that we are not adopting

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #12661:
URL: https://github.com/apache/arrow/pull/12661#discussion_r831128968



##########
File path: docs/source/developers/cpp/development.rst
##########
@@ -85,6 +85,8 @@ This project follows `Google's C++ Style Guide
   conveniences.  For private headers the rules are relaxed further and structs
   can be used where convenient for types that do not need access control even
   though they may not be simple data containers.
+* We prefer pointers for output and input/output parameters (the
+  style guide recommends mutable references in some cases).

Review comment:
       Thanks for this. I would remove "minor" above from the "minor exceptions" wording since this is a significant deviation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org