[GitHub] [geode] BalaKaza opened a new pull request, #7552: GEODE-10198: Fix LINSERT's case-sensitivity for arguments

[GitBox <gi...@apache.org>]

BalaKaza opened a new pull request, #7552:
URL: https://github.com/apache/geode/pull/7552

   LINSERT was case-sensitive with its arguments BEFORE/AFTER.Redis
   implementation of LINSERT is not case-sensitive.
   
   Authored-by: Bala Kaza Venkata <bk...@vmware.com>
   
   <!-- Thank you for submitting a contribution to Apache Geode. -->
   
   <!-- In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken: 
   -->
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   <!-- Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #7552: GEODE-10198: Fix LINSERT's case-sensitivity for arguments

[GitBox <gi...@apache.org>]

jdeppe-pivotal merged PR #7552:
URL: https://github.com/apache/geode/pull/7552


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] DonalEvans commented on a diff in pull request #7552: GEODE-10198: Fix LINSERT's case-sensitivity for arguments

[GitBox <gi...@apache.org>]

DonalEvans commented on code in PR #7552:
URL: https://github.com/apache/geode/pull/7552#discussion_r842847511


##########
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LInsertExecutor.java:
##########
@@ -39,10 +39,10 @@ public RedisResponse executeCommand(Command command, ExecutionHandlerContext con
     boolean before;
     byte[] referenceElement = commandElements.get(3);
     byte[] elementToInsert = commandElements.get(4);
-
-    if (Arrays.equals(direction, BEFORE)) {
+    String directionInUppercase = new String(direction).toUpperCase();

Review Comment:
   Rather than creating a new String here, line 38 should be 
   ```
   byte[] direction = toUpperCaseBytes(commandElements.get(2));
   ```
   The whole point of doing the byte array comparison with the constants from `StringBytesGlossary` is to avoid having to create a String.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org