[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22457: Remove the exclamation mark in the proxy's global rule configuration #22329

[GitBox <gi...@apache.org>]

RaigorJiang commented on code in PR #22457:
URL: https://github.com/apache/shardingsphere/pull/22457#discussion_r1033164293


##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/config/ProxyConfigurationLoader.java:
##########
@@ -85,6 +88,18 @@ private static YamlProxyServerConfiguration loadServerConfiguration(final File y
         if (null != result.getAuthority()) {
             result.getRules().add(result.getAuthority().convertToYamlAuthorityRuleConfiguration());
         }
+        result.getRules().removeIf(each -> each instanceof YamlTransactionRuleConfiguration);

Review Comment:
   I suggest adding an interface `YamlGlobalRuleConfiguration`, which can help us remove duplicate code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org