You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by as...@apache.org on 2012/04/20 06:50:53 UTC

svn commit: r1328198 - /ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java

Author: ashish
Date: Fri Apr 20 04:50:53 2012
New Revision: 1328198

URL: http://svn.apache.org/viewvc?rev=1328198&view=rev
Log:
Applied similar fix as we did on trunk r1300463. 
On production systems you can't suppress Debug.log( message by the use of debug.properties file. It is always good to use Debug.* statements that are having log level setup in debug.properties file. The real problem comes with Debug.log( statement when you are printing any list or map object that contains so many records(or data) in it. Here I am changing all the occurrence of Debug.log( with Debug.logInfo(, Debug.logError( or Debug.logWarning( so that we can have better control of Debug.* statements on production system. :-)

Bad use of Debug statement. On production system you will get false alarm that you are having error in code base although the resultant statement is only giving additional information instead of error message.

Modified:
    ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java

Modified: ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java?rev=1328198&r1=1328197&r2=1328198&view=diff
==============================================================================
--- ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java (original)
+++ ofbiz/branches/release10.04/applications/product/src/org/ofbiz/product/inventory/InventoryServices.java Fri Apr 20 04:50:53 2012
@@ -585,7 +585,7 @@ public class InventoryServices {
                         Timestamp cancelDate = (Timestamp) cancelItems.get(orderItemSeqId);
                         Timestamp currentCancelDate = orderItem.getTimestamp("autoCancelDate");
 
-                        Debug.logError("OI: " + orderId + " SEQID: "+ orderItemSeqId + " cancelAll: " + cancelAll + " cancelDate: " + cancelDate, module);
+                        Debug.logInfo("OI: " + orderId + " SEQID: "+ orderItemSeqId + " cancelAll: " + cancelAll + " cancelDate: " + cancelDate, module);
                         if (backOrderedItems.containsKey(orderItemSeqId)) {
                             orderItem.set("estimatedShipDate", shipDate);