You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/01 12:26:16 UTC

[GitHub] [incubator-devlake] e2corporation commented on a diff in pull request #2887: fix: connection saving must return after 2 seconds even though the ne…

e2corporation commented on code in PR #2887:
URL: https://github.com/apache/incubator-devlake/pull/2887#discussion_r960590211


##########
config-ui/src/hooks/useConnectionManager.jsx:
##########
@@ -256,13 +256,16 @@ function useConnectionManager (
       }
     }
 
+    let savePromise
     if (updateMode && activeConnection?.id !== null) {
       modifyConfiguration(connectionPayload)
+      savePromise = modifyConfiguration(connectionPayload)

Review Comment:
   @likyh Just now noticing you called `modifyConfiguration twice`? On lines 261 and 262, and same for `saveConfiguration` on `264` and `265` this isn't right you are sending 2 post requests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org