You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "oboki (via GitHub)" <gi...@apache.org> on 2023/04/02 09:08:10 UTC

[GitHub] [airflow] oboki commented on a diff in pull request #30310: In `DockerOperator`, adding an attribute `tls_verify` to choose whether to validate certificate (#30309)

oboki commented on code in PR #30310:
URL: https://github.com/apache/airflow/pull/30310#discussion_r1155271823


##########
airflow/providers/docker/operators/docker.py:
##########
@@ -186,6 +187,7 @@ def __init__(
         tls_ca_cert: str | None = None,
         tls_client_cert: str | None = None,
         tls_client_key: str | None = None,
+        tls_verify: bool | None = None,

Review Comment:
   @hussein-awala  Compared to the latest released version, I thought it would be better to leave it `True`.
   As shown in the [link](https://github.com/apache/airflow/blob/main/airflow/providers/docker/hooks/docker.py#L109), in the latest released version, the `verify` value is fixed as `True`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org