You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "felixb (via GitHub)" <gi...@apache.org> on 2024/03/04 12:46:53 UTC

[I] Latest release (3.1.1) missing arm64 docker images [superset]

felixb opened a new issue, #27378:
URL: https://github.com/apache/superset/issues/27378

   ### Bug description
   
   While 3.1.0 was still available as arm64 and amd64 docker image, the 3.1.1 release is only available for amd64.
   Thus the deployment on arm64 CPUs (e.g. AWS graviton) fails.
   
   There are quite some similar issues here already referring to developer images for apple's CPUs.
   The workaround given for those won't work on k8s clusters running on arm64 nodes.
   
   ### How to reproduce the bug
   
   1. Check out the listed architectures for the release docker image: https://hub.docker.com/r/apache/superset/tags?page=1&name=3.1.1
   
   ### Screenshots/recordings
   
   _No response_
   
   ### Superset version
   
   3.1.1
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-2040727351

   Ok I opened a PR fixing it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-1977888021

   I think we should be able to close this once the job finishes and we confirm that:
   - 3.1.1 is all multi-platform
   - we'll pick that cherry moving forward
   - we'll trigger manual runs for 3.x releases :(
   
   We could create a cherry with fresher actions, but hoping we can just move on with our lives to 4.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-1977881932

   For the record, job is running here -> https://github.com/apache/superset/actions/runs/8150387426/job/22276578594
   
   Explaining a bit more the intricacy of the different between a `release` GHA trigger and and `workflow_dispatch` on master... The former will use the old GHAs defined in the branch, while the `master` trigger will use the GHA definitions on `master`, pull the right branch, and run the build based on that. Subtle difference, but the reason for the issue here... For older release/re-release, we'll have to manually dispatch from `master` as such:
   <img width="1299" alt="Screenshot 2024-03-04 at 6 55 08 PM" src="https://github.com/apache/superset/assets/487433/9698364f-2414-4e29-9b4c-abe48f792828">
   
   Moving forward, it shouldn't be an issue, unless we want to retroactively change some of the logic, say if we wanted to introduce a third build platform retroactively, we'd have to fiddle with things, trigger from `master`, ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina closed issue #27378: Latest release (3.1.1) missing arm64 docker images
URL: https://github.com/apache/superset/issues/27378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-1977874225

   Oh I think this is related to the branch being cut prior to the multi-platform changes in `master`. Hoping the 4.x cuts will include what's need in the branch itself.
   
   To remedy this for that branch I just triggered the workflow dispatched manually from `master`. Oh, and I had to `cherry-pick 0cd2431989` the same way I had done in `3.1.0` and somehow didn't make the cut for `3.1.1` (I never told anyone I squeezed in this cherry, thinking it was pretty minor, hard to explain change). That cherry is bringing a newer Dockerfile that prevents a race condition that happens when dual-platform building in parallel (both docker build processes fight for locally-mounted apt-get work folders, which we move away from that approach in that newer dockerfile)
   
   @michael-s-molina I know it's not super clean, but I moved the tag `3.1.1` to include that cherry. How do we make sure it gets picked in 3.1.2+?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-2040246615

   @mistercrunch I tried to manually build 3.1.2 but I'm getting errors:
   
   <img width="359" alt="Screenshot 2024-04-05 at 13 44 58" src="https://github.com/apache/superset/assets/70410625/997b8063-4e4d-4ff1-ac58-c73080669ab7">
   
   <img width="1024" alt="Screenshot 2024-04-05 at 13 43 58" src="https://github.com/apache/superset/assets/70410625/b29bb758-cda3-4aeb-9181-6e24b729b730">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-2040518676

   Ok I'm on it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [I] Latest release (3.1.1) missing arm64 docker images [superset]

Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on issue #27378:
URL: https://github.com/apache/superset/issues/27378#issuecomment-1983355109

   > 3.1.1 is all multi-platform
   
   https://hub.docker.com/r/apache/superset/tags?page=1&name=3.1.1
   
   <img width="1247" alt="Screenshot 2024-03-07 at 08 51 57" src="https://github.com/apache/superset/assets/70410625/0616d674-22a0-4b56-8d02-9c0275717fa4">
   
   > we'll pick that cherry moving forward
   
   Added https://github.com/apache/superset/pull/26205 as a cherry for 3.1.
   
   > we'll trigger manual runs for 3.x releases :(
   
   Will do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org