You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ab...@apache.org on 2019/11/28 00:51:43 UTC

svn commit: r1870523 - in /poi/trunk/src/ooxml: java/org/apache/poi/xslf/usermodel/XSLFTable.java testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java

Author: abearez
Date: Thu Nov 28 00:51:43 2019
New Revision: 1870523

URL: http://svn.apache.org/viewvc?rev=1870523&view=rev
Log:
Fix addition and removal of columns in XSLTTable

Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTable.java
    poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTable.java?rev=1870523&r1=1870522&r2=1870523&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTable.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTable.java Thu Nov 28 00:51:43 2019
@@ -179,6 +179,9 @@ public class XSLFTable extends XSLFGraph
         long width = _table.getTblGrid().getGridColArray(_table.getTblGrid().sizeOfGridColArray() - 1).getW();
         CTTableCol col = _table.getTblGrid().addNewGridCol();
         col.setW(width);
+        for(CTTableRow row : _table.getTrList()) {
+            row.addNewTc();
+        }
         updateRowColIndexes();
     }
 
@@ -194,6 +197,9 @@ public class XSLFTable extends XSLFGraph
         long width = _table.getTblGrid().getGridColArray(colIdx).getW();
         CTTableCol col = _table.getTblGrid().insertNewGridCol(colIdx);
         col.setW(width);
+        for(CTTableRow row : _table.getTrList()) {
+            row.insertNewTc(colIdx);
+        }
         updateRowColIndexes();
     }
 
@@ -204,6 +210,9 @@ public class XSLFTable extends XSLFGraph
      */
     public void removeColumn(int colIdx) {
         _table.getTblGrid().removeGridCol(colIdx);
+        for(CTTableRow row : _table.getTrList()) {
+            row.removeTc(colIdx);
+        }
         updateRowColIndexes();
     }
 

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java?rev=1870523&r1=1870522&r2=1870523&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTable.java Thu Nov 28 00:51:43 2019
@@ -71,6 +71,7 @@ public class TestXSLFTable {
             tab.insertColumn(0);
             assertEquals(tab.getColumnWidth(1), tab.getColumnWidth(0), 0.00001);
             tab.addColumn();
+            tab.getCell(0, data[0].length + 1);
             assertEquals(tab.getColumnWidth(tab.getNumberOfColumns() - 2), tab.getColumnWidth(tab.getNumberOfColumns() - 1), 0.00001);
             tab.removeColumn(0);
             tab.removeColumn(tab.getNumberOfColumns() - 1);



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org