[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4975: Revert alias

[GitBox <gi...@apache.org>]

ocket8888 opened a new pull request #4975:
URL: https://github.com/apache/trafficcontrol/pull/4975


   ## What does this PR (Pull Request) do?
   - [x] This PR is not related to any Issue
   
   This reverts the "rolling alias" `github.com/apache/trafficcontrol/lib/go-tc.DeliveryServiceNullable` rolling forward to be an alias for `github.com/apache/trafficcontrol/lib/go-tc.DeliveryServiceNullableV30`. That change was breaking; people who made programs that imported `github.com/apache/trafficcontrols/traffic_ops/client` and used its Delivery Service methods to interact with Delivery Services will suddenly have their returned and passed data interpreted differently. After this change, those symbols will be pinned to `tc.DeliveryServiceNullableV15` as before, and new client methods were added to the v3-client to specifically deal with the version 3.0 structures. Methods that deal with the legacy structures are marked as deprecated, and should be removed at the same time as the un-versioned client package. All v3 tests, atstccfg code, and API code dealing with DeliveryServiceNullable structures have been updated to use DeliveryServiceNullableV30 where appropriate.
   
   ## Which Traffic Control components are affected by this PR?
   - CDN in a Box
   - Documentation
   - Traffic Ops Client (Go)
   - Traffic Ops
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run all unit and client/API integration tests. Which actions now do for you :wink: .
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests
   - [x] This PR includes documentation
   - [x] An update to CHANGELOG.md is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] mitchell852 merged pull request #4975: Revert Delivery Service type alias

[GitBox <gi...@apache.org>]

mitchell852 merged pull request #4975:
URL: https://github.com/apache/trafficcontrol/pull/4975


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org