You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/12 07:41:10 UTC
[GitHub] [superset] iercan opened a new issue #13089: It is not possible to edit a database if it is not accessible
iercan opened a new issue #13089:
URL: https://github.com/apache/superset/issues/13089
We have a database connection that is not accessible anymore. I want to remove it from sql lab view but since database is not accessible I'm getting error in the picture.
### Expected results
Database should be saved successfully.
### Actual results
Giving below error and doesn't save
#### How to reproduce the bug
1. Add any database
2. Make database inaccessible
3. Try to edit database sqllab settings (i.e. disable sql lab expose)
### Environment
(please complete the following information):
- superset version: 1.0.1
- python version: 3.7
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #13089: It is not possible to edit a database if it is not accessible
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #13089:
URL: https://github.com/apache/superset/issues/13089#issuecomment-778092423
No I don't want to remove database in case I may use it in future. Also this is not just about sqllab, database is not editable in anyway if it is inaccessible. I just gave sqllab situation as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] iercan commented on issue #13089: It is not possible to edit a database if it is not accessible
Posted by GitBox <gi...@apache.org>.
iercan commented on issue #13089:
URL: https://github.com/apache/superset/issues/13089#issuecomment-778100080
I just wanted to disable it from sqllab for more clear view. I think there is no need to fail because of a connection issue for every update action while there is a 'test connection' button there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on issue #13089: It is not possible to edit a database if it is not accessible
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #13089:
URL: https://github.com/apache/superset/issues/13089#issuecomment-778095403
Yes, I understand now. By design when an update is done, superset fetches the existing schemas from the db and updates the necessary security permissions. This behaviour can probably be improved if it's a problem to not be able to edit for example SQLLab database properties.
Can you explain in more detail, your use case for editing SQLLab properties for a database that is not accessible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on issue #13089: It is not possible to edit a database if it is not accessible
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #13089:
URL: https://github.com/apache/superset/issues/13089#issuecomment-778088872
Every DB connection you create is shown on SQLLab (if the user has permissions for it). On this case I think you actually want to remove the connection (delete the record from the db connection list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org