You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/13 13:37:32 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #7522: Ensure the create subscription can be completed when the operation timeout happens

codelipenghui opened a new pull request #7522:
URL: https://github.com/apache/pulsar/pull/7522


   Fixes #7521
   
   ### Motivation
   
   Ensure the create subscription can be completed when the operation timeout happens
   
   ### Verifying this change
   
   New tests added.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #7522: Ensure the create subscription can be completed when the operation timeout happens

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7522:
URL: https://github.com/apache/pulsar/pull/7522


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on a change in pull request #7522: Ensure the create subscription can be completed when the operation timeout happens

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #7522:
URL: https://github.com/apache/pulsar/pull/7522#discussion_r453658399



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
##########
@@ -920,7 +919,6 @@ private void handleSubscribeOneTopicError(String topicName, Throwable error, Com
                         log.warn("[{}] Failed to subscribe for topic [{}] in topics consumer, subscribe error: {}",
                             topic, topicName, error.getMessage());
                         topics.remove(topicName);
-                        checkState(allTopicPartitionsNumber.get() == consumers.values().size());

Review comment:
       This is one topic subscribe error, so we should remove the check with all topic partitions number, Otherwise, the one topic subscribe future can't complete.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #7522: Ensure the create subscription can be completed when the operation timeout happens

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7522:
URL: https://github.com/apache/pulsar/pull/7522#issuecomment-657637333


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org