You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by sz...@apache.org on 2014/04/02 03:00:45 UTC
svn commit: r1583842 - in
/hadoop/common/trunk/hadoop-common-project/hadoop-common: CHANGES.txt
src/main/java/org/apache/hadoop/ipc/Server.java
Author: szetszwo
Date: Wed Apr 2 01:00:44 2014
New Revision: 1583842
URL: http://svn.apache.org/r1583842
Log:
HADOOP-10455. When there is an exception, ipc.Server should first check whether it is an terse exception.
Modified:
hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1583842&r1=1583841&r2=1583842&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Wed Apr 2 01:00:44 2014
@@ -350,6 +350,9 @@ Release 2.4.1 - UNRELEASED
BUG FIXES
+ HADOOP-10455. When there is an exception, ipc.Server should first check
+ whether it is an terse exception. (szetszwo)
+
Release 2.4.0 - 2014-04-07
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java?rev=1583842&r1=1583841&r2=1583842&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java Wed Apr 2 01:00:44 2014
@@ -2107,16 +2107,15 @@ public abstract class Server {
if (e instanceof UndeclaredThrowableException) {
e = e.getCause();
}
- String logMsg = Thread.currentThread().getName() + ", call " + call + ": error: " + e;
- if (e instanceof RuntimeException || e instanceof Error) {
+ String logMsg = Thread.currentThread().getName() + ", call " + call;
+ if (exceptionsHandler.isTerse(e.getClass())) {
+ // Don't log the whole stack trace. Way too noisy!
+ LOG.info(logMsg + ": " + e);
+ } else if (e instanceof RuntimeException || e instanceof Error) {
// These exception types indicate something is probably wrong
// on the server side, as opposed to just a normal exceptional
// result.
LOG.warn(logMsg, e);
- } else if (exceptionsHandler.isTerse(e.getClass())) {
- // Don't log the whole stack trace of these exceptions.
- // Way too noisy!
- LOG.info(logMsg);
} else {
LOG.info(logMsg, e);
}