[GitHub] [daffodil] tuxji commented on a diff in pull request #945: Normalize whitespace in simple type constructors with string values

["tuxji (via GitHub)" <gi...@apache.org>]

tuxji commented on code in PR #945:
URL: https://github.com/apache/daffodil/pull/945#discussion_r1094710130


##########
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml:
##########
@@ -6805,7 +6812,8 @@
     <xs:element name="dfdlULong09" type="xs:unsignedLong" dfdl:inputValueCalc="{ dfdl:unsignedLong(dfdl:hexBinary(9223372036854775807)) }"/> <!-- valid -->
     <xs:element name="dfdlULong11" type="xs:unsignedLong" dfdl:inputValueCalc="{ dfdl:unsignedLong('xFFFFFFFFFFFFFFFG') }"/> <!-- invalid -->
     <xs:element name="dfdlULong12" type="xs:unsignedLong" dfdl:inputValueCalc="{ dfdl:unsignedLong(-1) }"/> <!-- invalid -->
-    
+    <xs:element name="dfdlULong13" type="xs:unsignedLong" dfdl:inputValueCalc="{ dfdl:unsignedLong('  18446744073709551615') }"/> <!-- valid -->

Review Comment:
   The JIRA issue says XPath performs whitespace normalization which removes leading AND trailing whitespace.  None of your new tests have any trailing whitespace, even though the trim method will remove it too.  Other than that, I'll let Mike and Steve review.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org