You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Woody Anderson (JIRA)" <ji...@apache.org> on 2011/04/09 00:15:11 UTC

[jira] [Created] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
-------------------------------------------------------------------------------------------

                 Key: PIG-1985
                 URL: https://issues.apache.org/jira/browse/PIG-1985
             Project: Pig
          Issue Type: Bug
          Components: impl
    Affects Versions: 0.9.0
            Reporter: Woody Anderson
             Fix For: 0.9.0


I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:

{code}
Utils.getSchemaFromString("f: map[]")
{code}
results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}

{code}
Utils.getSchemaFromString("f: map[int]")
{code}
results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
..
org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
Was expecting one of:
    "int" ...
    "long" ...
    "float" ...
    "double" ...
    "chararray" ...
    "bytearray" ...
    "int" ...
    "long" ...
    "float" ...
    "double" ...
    "chararray" ...
    "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022975#comment-13022975 ] 

Daniel Dai commented on PIG-1985:
---------------------------------

Migrate the typed schema parser back to old logical plan, so that Utils.getSchemaFromString can be used.

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>            Assignee: Daniel Dai
>             Fix For: 0.9.0, 0.10
>
>         Attachments: PIG-1985-1.patch
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Woody Anderson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017727#comment-13017727 ] 

Woody Anderson commented on PIG-1985:
-------------------------------------

this is a bug, why are we targeting for .10?

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>             Fix For: 0.10
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-1985:
----------------------------

    Attachment: PIG-1985-1.patch

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>            Assignee: Daniel Dai
>             Fix For: 0.9.0, 0.10
>
>         Attachments: PIG-1985-1.patch
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1985:
--------------------------------

    Fix Version/s: 0.9.0

Ok. Switched back to 0.9. I am ok with fixing the bug but no ok with switching parser technology so late in the cycle

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>             Fix For: 0.9.0, 0.10
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-1985:
--------------------------------

    Fix Version/s:     (was: 0.9.0)
                   0.10

It is too late to make this kind of changes for 9. Moving to 10

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>             Fix For: 0.10
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai reassigned PIG-1985:
-------------------------------

    Assignee: Daniel Dai

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>            Assignee: Daniel Dai
>             Fix For: 0.9.0, 0.10
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai resolved PIG-1985.
-----------------------------

    Resolution: Fixed

This is done as part of PIG-1775. There is no need for this patch. Close the ticket.

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>            Assignee: Daniel Dai
>             Fix For: 0.9.0, 0.10
>
>         Attachments: PIG-1985-1.patch
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (PIG-1985) Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema

Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017764#comment-13017764 ] 

Alan Gates commented on PIG-1985:
---------------------------------

It seems like we're confusing wrong behavior and the solution here.  The bug is that Utils.getSchemaFromString doesn't support the new syntax.  It isn't a bug that it doesn't use the new parser.  We can fix this in whatever parser it uses.

I agree that this is a bug against 0.9.  It means we didn't fully implement changes to support typed maps.

> Utils.getSchemaFromString does not use the new parser, and thus fails to parse valid schema
> -------------------------------------------------------------------------------------------
>
>                 Key: PIG-1985
>                 URL: https://issues.apache.org/jira/browse/PIG-1985
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.9.0
>            Reporter: Woody Anderson
>             Fix For: 0.10
>
>
> I've been told this is because Utils.getSchemaFromString does not use the new parser to parse the schema, so we should update the impl to use the new parser:
> {code}
> Utils.getSchemaFromString("f: map[]")
> {code}
> results in: (org.apache.pig.impl.logicalLayer.schema.Schema) {f: map[]}
> {code}
> Utils.getSchemaFromString("f: map[int]")
> {code}
> results in: An exception occurred: org.apache.pig.impl.logicalLayer.parser.ParseException
> ..
> org.apache.pig.impl.logicalLayer.parser.ParseException: Encountered " "map" "map "" at line 1, column 4.
> Was expecting one of:
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...
>     "int" ...
>     "long" ...
>     "float" ...
>     "double" ...
>     "chararray" ...
>     "bytearray" ...	 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira