[jira] [Resolved] (CALCITE-4332) Improve error when planning rule produces a relational expression with wrong row type

["Chunwei Lei (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chunwei Lei resolved CALCITE-4332.
----------------------------------
    Fix Version/s: 1.27.0
       Resolution: Fixed

Fixed in https://github.com/apache/calcite/commit/f9d23a62145e8c490492214836ce9cd7d1dcc35e.

> Improve error when planning rule produces a relational expression with wrong row type
> -------------------------------------------------------------------------------------
>
>                 Key: CALCITE-4332
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4332
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: Vladimir Sitnikov
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> Current code in {{VolcanoPlanner}}:
> {code:java}
>       assert RelOptUtil.equal(
>           "rel rowtype",
>           rel.getRowType(),
>           "equivRel rowtype",
>           equivRel.getRowType(),
>           Litmus.THROW);
>       equivRel = ensureRegistered(equivRel, null);
> {code}
> The suggested changes:
> 1) Use regular error {{IllegalArgumentException}} rather than an assertion
> 2) Make sure the exception message contains fine-grained information on what went wrong. For instance: {{name: non nullable -> nullable; description: character -> int; ...}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)