You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/05/30 14:26:15 UTC
[GitHub] [incubator-eventmesh] eight-nines opened a new pull request, #897: Webhook
eight-nines opened a new pull request, #897:
URL: https://github.com/apache/incubator-eventmesh/pull/897
webhook receive module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #897: Webhook
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on code in PR #897:
URL: https://github.com/apache/incubator-eventmesh/pull/897#discussion_r885388234
##########
eventmesh-webhook/eventmesh-webhook-api/src/main/java/org/apache/eventmesh/webhook/api/WebHookConfig.java:
##########
@@ -75,7 +75,9 @@ public class WebHookConfig {
private String cloudEventName;
/**
- * 如果是http协议就需要标记请求头 contentType的类型
+ * 转出数据格式 -> 指定如何将 CloudEvent 序列化为字节序列
+ * 如果是http协议就需要标记请求头 contentType的类型
+ * contentType -> DataContentType
*/
private String DataContentType;
Review Comment:
the code comments please change to English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #897: Webhook
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #897:
URL: https://github.com/apache/incubator-eventmesh/pull/897#issuecomment-1140636446
@eight-nines please fix the conflicts, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #897: Webhook
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged PR #897:
URL: https://github.com/apache/incubator-eventmesh/pull/897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] eight-nines closed pull request #897: Webhook
Posted by GitBox <gi...@apache.org>.
eight-nines closed pull request #897: Webhook
URL: https://github.com/apache/incubator-eventmesh/pull/897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #897: Webhook
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on code in PR #897:
URL: https://github.com/apache/incubator-eventmesh/pull/897#discussion_r885384765
##########
eventmesh-webhook/eventmesh-webhook-api/src/main/java/org/apache/eventmesh/webhook/api/WebHookConfig.java:
##########
@@ -75,7 +75,9 @@ public class WebHookConfig {
private String cloudEventName;
/**
- * 如果是http协议就需要标记请求头 contentType的类型
+ * 转出数据格式 -> 指定如何将 CloudEvent 序列化为字节序列
+ * 如果是http协议就需要标记请求头 contentType的类型
+ * contentType -> DataContentType
*/
private String DataContentType;
Review Comment:
DataContentType -> dataContentType ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org