[GitHub] [iotdb] samperson1997 commented on a change in pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

[GitBox <gi...@apache.org>]

samperson1997 commented on a change in pull request #1524:
URL: https://github.com/apache/iotdb/pull/1524#discussion_r509959632



##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -232,14 +232,16 @@ write_read_free_memory_proportion=4:3:1:2
 primitive_array_size=32
 
 # Ratio of memory allocated for buffered arrays, 0.6 by default
-buffered_arrays_memory_proportion=0.4
+buffered_arrays_memory_proportion=0.6
 
 # Flush proportion for system, 0.5 by default
 flush_proportion=0.5
 
 # Reject proportion for system, 0.8 by default
 reject_proportion=0.8
 
+# If storage group increased more than this threshold, report to system. The default value is 16777216

Review comment:
       ```suggestion
   # If storage group increased more than this threshold (in byte), report to system. The default value is 16MB
   ```

##########
File path: server/src/test/java/org/apache/iotdb/db/utils/datastructure/LongTVListTest.java
##########
@@ -30,7 +32,7 @@
 
 
   @Test
-  public void testLongTVList1() {
+  public void testLongTVList1() throws WriteProcessException {

Review comment:
       no need to throw `WriteProcessException` in this test : )

##########
File path: server/src/test/java/org/apache/iotdb/db/utils/datastructure/LongTVListTest.java
##########
@@ -21,6 +21,8 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Random;
+
+import org.apache.iotdb.db.exception.WriteProcessException;

Review comment:
       remove unused import




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org