[GitHub] [flink-docker] rmetzger commented on a change in pull request #53: [FLINK-20632] Add script to publish docker images to Github Packages

[GitBox <gi...@apache.org>]

rmetzger commented on a change in pull request #53:
URL: https://github.com/apache/flink-docker/pull/53#discussion_r552513812



##########
File path: README.md
##########
@@ -83,7 +83,14 @@ Updating the Dockerfiles involves the following steps:
       https://github.com/apache/flink-docker/commit/5920fd775ca1a8d03ee959d79bceeb5d6e8f35a1)]</sup>
     * Create a pull request against the `master` branch containing this commit.
 
-Once the pull request has been merged, a new manifest should be generated and a pull request opened
+Once the pull request has been merged, we can release the new docker images:
+
+For **publishing as a GitHub Package**, you need to perform the following steps:
+
+1. Login to your GitHub using Docker: `docker login https://docker.pkg.github.com -u <username>`. You will need to use a Personal Access Token (GitHub settings / Developer Settings / Personal access tokens) with the `write:packages` permission.

Review comment:
       The login seems to be a permanent, one-time action. I'm not sure if it's worth it adding it to the script




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org