You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by maskit <gi...@git.apache.org> on 2016/08/21 05:28:58 UTC
[GitHub] trafficserver pull request #885: TS-4546: Fix a build error on OmniOS
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/885
TS-4546: Fix a build error on OmniOS
https://issues.apache.org/jira/browse/TS-4546
OmniOS doesn't have d_type in dirent structure, so use stat() instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/trafficserver ts4546
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/885.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #885
----
commit 651d98a8a7e3c886530fdcfeeb0e0e8399569a80
Author: Masakazu Kitajo <ma...@apache.org>
Date: 2016-08-21T05:21:08Z
TS-4546: Fix a build error on OmniOS
OmniOS doesn't have d_type in dirent structure, so use stat() instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #885: TS-4546: Fix a build error on OmniOS
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/885
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/468/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #885: TS-4546: Fix a build error on OmniOS
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/885
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/465/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #885: TS-4546: Fix a build error on OmniOS
Posted by maskit <gi...@git.apache.org>.
Github user maskit closed the pull request at:
https://github.com/apache/trafficserver/pull/885
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #885: TS-4546: Fix a build error on OmniOS
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/885
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #885: TS-4546: Fix a build error on OmniOS
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/885
Updated.
- Use PATH_MAX
- Use ink_strlcat
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #885: TS-4546: Fix a build error on OmniOS
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/885#discussion_r75606773
--- Diff: proxy/http2/test_HPACK.cc ---
@@ -328,8 +328,14 @@ prepare()
cerr << "Cannot open " << input_dir << endl;
return 1;
}
+ struct stat st;
+ char name[1024] = "";
--- End diff --
```char name[PATH_MAX + 1]```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #885: TS-4546: Fix a build error on OmniOS
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/885#discussion_r75606779
--- Diff: proxy/http2/test_HPACK.cc ---
@@ -328,8 +328,14 @@ prepare()
cerr << "Cannot open " << input_dir << endl;
return 1;
}
+ struct stat st;
+ char name[1024] = "";
+ strcat(name, input_dir.c_str());
while ((d = readdir(dir)) != NULL) {
- if (d->d_type == DT_REG) {
+ name[input_dir.length()] = '\0';
+ strcat(name, d->d_name);
--- End diff --
```ink_strlcat(...)```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #885: TS-4546: Fix a build error on OmniOS
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/885
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/572/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #885: TS-4546: Fix a build error on OmniOS
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/885
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/569/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---