You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/11/20 22:06:16 UTC
[GitHub] zeppelin pull request #1660: [WIP][ZEPPELIN-1594] Personalized mode
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/1660
[WIP][ZEPPELIN-1594] Personalized mode
### What is this PR for?
Support personalized mode in multi user environments.
### What type of PR is it?
[Feature]
### Todos
* [x] - Add the method to send the result to specific user
* [ ] - Add the UI to toggle "personlized mode" in a note
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1594
### How should this be tested?
1. Apply this patch
2. Enable shiro
3. note.config.personalizedMode = true in a note.json to be tested
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes
This covers the first Todo only. @cloverhearts @1ambda Can you help me implement in a front-side?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1594
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1660
----
commit f23e4f34d07c18405d3a7b05d8903dd5c1973354
Author: Jongyoul Lee <jo...@gmail.com>
Date: 2016-11-20T22:01:30Z
Added the logic to check if personalized mode turns on or not
Added the method to send note update to specific user
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@1ambda
hmm.. But, this PR does not seem to have an implementation for the personalization toggle.
This PR seems to be implemented only in the context of the per user send when personalization mode.
hmm... I'm sorry.
(perhaps).. i did missing part?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1660
I think we need to implement the second todo item.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@jongyoul
Sure, What part are you helping me with?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@Leemoonsoo Yes, I haven't check the front-side. I'll fix it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@jongyoul I think key requirement of personalized mode is two or more different user want to keep their own dynamic form input and the output of paragraph. How can this be done without let user run paragraph?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@cloverhearts @1ambda Can you help me? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul closed the pull request at:
https://github.com/apache/zeppelin/pull/1660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@Leemoonsoo I've not tested the graph. If you mean a dynamic change of graph, I'll check it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@jongyoul Could you describe more about the personalized mode? I don't think current implementation is anywhere close to personalized mode discussed in https://issues.apache.org/jira/browse/ZEPPELIN-1236.
I think Personalized mode should be
* Keep boardcast every changes to every users who open the same note
* Zeppelin personalize parts of the Note, which is
- paragraph.result (output)
- paragraph.config.graph (graph selections)
- paragraph.settings (dynamic form)
So, every changes, like paragraph addition, deletion, change the code, change width,
everything is broadcasted, but only result / graph selection / dynamic form is personalized.
Current implementation will have following limitations
- Once user refresh the page, user will see the other result.
- Once two users changes note at the same time (i.e. update paragraph code, change paragraph order, etc), the result is undefined.
- Chart selection, dynamic form value is not personalized, which is major pain point that personalized mode try to resolve, i think.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@jongyoul thanks for starting work on it! one more question. with current implementation in case of refreshing the page, user will get last run note right? so for example, if `user2` runs note and `user1` refreshes, he'll still get results of `user1`. any roadmap on that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1660: [WIP][ZEPPELIN-1594] Personalized mode
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1660
@Leemoonsoo As we discussed before, the first version of personalized mode is to avoid changing note simultaneously while two user see a same note. I think this version fits it. one user want to change a paragraph or run a paragraph, and he has a proper permission, he can change it but the others doesn't see his change until they refresh their browser. but they refresh it, the newest one is adopted. Isn't it the first version of personalized mode?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---