[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9639: Fixes for xmc4700-relax board

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #9639:
URL: https://github.com/apache/nuttx/pull/9639#discussion_r1246960824


##########
arch/arm/src/xmc4/xmc4_spi.c:
##########
@@ -234,7 +233,7 @@ static inline struct xmc4_spidev_s *spi_device(struct xmc4_spics_s *spics);
 #ifdef CONFIG_DEBUG_SPI_INFO
 static void     spi_dumpregs(struct xmc4_spidev_s *spi, const char *msg);
 #else
-#  define       spi_dumpregs(spi, msg)
+# define        spi_dumpregs(spi, msg)

Review Comment:
   revert the change



##########
boards/arm/xmc4/xmc4700-relax/src/xmc4_bringup.c:
##########
@@ -26,9 +26,15 @@
 
 #include <debug.h>
 #include <errno.h>
-#include <nuttx/spi/spi_transfer.h>
 #include <sys/types.h>
 
+#ifdef CONFIG_XMC4_USCI_SPI
+  #include <nuttx/spi/spi_transfer.h>

Review Comment:
   ```
   #  include <nuttx/spi/spi_transfer.h>
   ```



##########
arch/arm/src/xmc4/xmc4_spi.c:
##########
@@ -222,7 +221,7 @@ static bool     spi_checkreg(struct xmc4_spidev_s *spi, bool wr,
                              uint32_t value, uint32_t address);
 
 #else
-#  define       spi_checkreg(spi, wr, value, address)  (false)
+# define        spi_checkreg(spi, wr, value, address)  (false)

Review Comment:
   revert the change



##########
boards/arm/xmc4/xmc4700-relax/src/xmc4_bringup.c:
##########
@@ -26,9 +26,15 @@
 
 #include <debug.h>
 #include <errno.h>
-#include <nuttx/spi/spi_transfer.h>
 #include <sys/types.h>
 
+#ifdef CONFIG_XMC4_USCI_SPI
+  #include <nuttx/spi/spi_transfer.h>
+#endif
+#ifdef CONFIG_USERLED
+  #include <nuttx/leds/userled.h>

Review Comment:
   ```
   #  include <nuttx/leds/userled.h>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org