You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/29 01:37:28 UTC

[GitHub] [pulsar] merlimat opened a new pull request, #17881: PIP-209: Removed C++/Python clients from main repo

merlimat opened a new pull request, #17881:
URL: https://github.com/apache/pulsar/pull/17881

   ### Motivation
   
   Removing C++ and Python client code from main repo
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [X] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [ ] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/merlimat/pulsar/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#issuecomment-1261641640

   Do we have the corresponding new repo now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat closed pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
merlimat closed pull request #17881: PIP-209: Removed C++/Python clients from main repo
URL: https://github.com/apache/pulsar/pull/17881


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tisonkun commented on a diff in pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#discussion_r982995960


##########
docker/pulsar/pom.xml:
##########
@@ -58,55 +52,11 @@
       <id>docker</id>
       <properties>
         <docker.buildArg.PULSAR_TARBALL>target/pulsar-server-distribution-${project.version}-bin.tar.gz</docker.buildArg.PULSAR_TARBALL>
+        <docker.buildArg.PULSAR_CLIENT_PYTHON_VERSION>${pulsar.client.python.version}</docker.buildArg.PULSAR_CLIENT_PYTHON_VERSION>
         <docker.buildArg.UBUNTU_MIRROR>${env.UBUNTU_MIRROR}</docker.buildArg.UBUNTU_MIRROR>
       </properties>
       <build>
         <plugins>
-          <!-- build Python client, copy the wheel file and then build docker image -->

Review Comment:
   Cool!



##########
pulsar-functions/instance/pom.xml:
##########
@@ -238,9 +238,6 @@
                 <echo>building python instance</echo>
                 <mkdir dir="${basedir}/target/python-instance"/>
                 <copydir src="${basedir}/src/main/python" dest="${basedir}/target/python-instance"/>
-                <mkdir dir="${basedir}/target/python-instance/pulsar"/>
-                <copydir src="${basedir}/../../pulsar-client-cpp/python/pulsar"
-                         dest="${basedir}/target/python-instance/pulsar"/>

Review Comment:
   Doesn't this removal cause file not found?



##########
src/stage-release.sh:
##########
@@ -38,12 +38,6 @@ cp $PULSAR_PATH/distribution/offloaders/target/apache-pulsar-offloaders-$VERSION
 
 cp -r $PULSAR_PATH/distribution/io/target/apache-pulsar-io-connectors-$VERSION-bin $DEST_PATH/connectors
 
-mkdir $DEST_PATH/RPMS
-cp -r $PULSAR_PATH/pulsar-client-cpp/pkg/rpm/RPMS/x86_64/* $DEST_PATH/RPMS
-
-mkdir $DEST_PATH/DEB
-cp -r $PULSAR_PATH/pulsar-client-cpp/pkg/deb/BUILD/DEB/* $DEST_PATH/DEB

Review Comment:
   Perhaps file a subtask under #17724 about correspondingly update release guide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on a diff in pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
merlimat commented on code in PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#discussion_r983948274


##########
pulsar-functions/instance/pom.xml:
##########
@@ -238,9 +238,6 @@
                 <echo>building python instance</echo>
                 <mkdir dir="${basedir}/target/python-instance"/>
                 <copydir src="${basedir}/src/main/python" dest="${basedir}/target/python-instance"/>
-                <mkdir dir="${basedir}/target/python-instance/pulsar"/>
-                <copydir src="${basedir}/../../pulsar-client-cpp/python/pulsar"
-                         dest="${basedir}/target/python-instance/pulsar"/>

Review Comment:
   No, this is just to avoid copying the Pulsar python lib files directly in the Pulsar functions directory, which was not needed anyway. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#issuecomment-1286435204

   I changed the doc label from `doc-required` to `doc-complete` since the related [doc PR](https://github.com/apache/pulsar/pull/17919) has been merged. Feel free to correct me if I misunderstand it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #17881:
URL: https://github.com/apache/pulsar/pull/17881


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on a diff in pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
merlimat commented on code in PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#discussion_r983948664


##########
src/stage-release.sh:
##########
@@ -38,12 +38,6 @@ cp $PULSAR_PATH/distribution/offloaders/target/apache-pulsar-offloaders-$VERSION
 
 cp -r $PULSAR_PATH/distribution/io/target/apache-pulsar-io-connectors-$VERSION-bin $DEST_PATH/connectors
 
-mkdir $DEST_PATH/RPMS
-cp -r $PULSAR_PATH/pulsar-client-cpp/pkg/rpm/RPMS/x86_64/* $DEST_PATH/RPMS
-
-mkdir $DEST_PATH/DEB
-cp -r $PULSAR_PATH/pulsar-client-cpp/pkg/deb/BUILD/DEB/* $DEST_PATH/DEB

Review Comment:
   Yes, we'll remove the C++ release step from the main Pulsar release guide.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat commented on pull request #17881: PIP-209: Removed C++/Python clients from main repo

Posted by GitBox <gi...@apache.org>.
merlimat commented on PR #17881:
URL: https://github.com/apache/pulsar/pull/17881#issuecomment-1261646577

   Yes, I just created the 2 repos with the current state of these libraries. The build system and CI of these repos will require some adjustments, though it's important the 2 changes are synchronized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org