You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/07/06 09:15:10 UTC
[PR] Fix SnowflakeSqlApiOperator polling to avoid needless sleeps [airflow]
amoghrajesh opened a new pull request, #69450:
URL: https://github.com/apache/airflow/pull/69450
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What
`SnowflakeSqlApiOperator.poll_on_queries()` polls the status of every submitted SQL API statement handle in a loop and waits `poll_interval` seconds between checks. It exists to avoid hammering the Snowflake SQL API while a query is still running.
### Current behaviour
The `time.sleep(self.poll_interval)` call sits inside the per-handle `for` loop, so it fires after every handle is checked, regardless of whether that handle (or any other) is still running. For a batch of N statement handles, a single call to `poll_on_queries()` can sleep for up to `N * poll_interval` seconds even when every handle already resolved to `success` or `error` on this pass. This adds pointless latency: a batch that just finished still waits before the operator can move on and report the result (or raise on failure).
### Proposed change
Move the sleep out of the per-handle loop to run at most once per call to `poll_on_queries()`, and only when at least one handle is still `running` after checking all of them. A cycle where everything already resolved (all succeeded, or one failed) now returns immediately instead of sleeping first.
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SnowflakeSqlApiOperator polling to avoid needless sleeps [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #69450:
URL: https://github.com/apache/airflow/pull/69450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SnowflakeSqlApiOperator polling to avoid needless sleeps [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #69450:
URL: https://github.com/apache/airflow/pull/69450#discussion_r3527944013
##########
providers/snowflake/tests/unit/snowflake/operators/test_snowflake.py:
##########
@@ -359,6 +359,49 @@ def test_poll_on_queries_raises_runtime_error_on_status_check_failure(
with pytest.raises(RuntimeError, match="Failed to get status for query uuid1"):
operator.poll_on_queries()
+ def test_poll_on_queries_no_sleep_when_all_resolved(
+ self, mock_execute_query, mock_get_sql_api_query_status
+ ):
Review Comment:
```suggestion
def test_poll_on_queries_no_sleep_when_all_resolved(
self, mock_get_sql_api_query_status
):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SnowflakeSqlApiOperator polling to avoid needless sleeps [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #69450:
URL: https://github.com/apache/airflow/pull/69450#discussion_r3527955048
##########
providers/snowflake/tests/unit/snowflake/operators/test_snowflake.py:
##########
@@ -359,6 +359,49 @@ def test_poll_on_queries_raises_runtime_error_on_status_check_failure(
with pytest.raises(RuntimeError, match="Failed to get status for query uuid1"):
operator.poll_on_queries()
+ def test_poll_on_queries_no_sleep_when_all_resolved(
+ self, mock_execute_query, mock_get_sql_api_query_status
+ ):
+ operator = SnowflakeSqlApiOperator(
+ task_id=TASK_ID,
+ snowflake_conn_id="snowflake_default",
+ sql=SQL_MULTIPLE_STMTS,
+ statement_count=4,
+ do_xcom_push=False,
+ )
+ operator.query_ids = ["uuid1", "uuid2"]
+ mock_get_sql_api_query_status.side_effect = [{"status": "success"}, {"status": "error"}]
+
+ with mock.patch("time.sleep") as mock_sleep:
+ result = operator.poll_on_queries()
+
+ mock_sleep.assert_not_called()
+ assert result["success"] == {"uuid1": {"status": "success"}}
+ assert result["error"] == {"uuid2": {"status": "error"}}
+ assert result["running"] == {}
+
+ def test_poll_on_queries_sleeps_once_per_cycle(self, mock_execute_query, mock_get_sql_api_query_status):
Review Comment:
same comment as above, `mock_execute_query` can be removed from the signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SnowflakeSqlApiOperator polling to avoid needless sleeps [airflow]
Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #69450:
URL: https://github.com/apache/airflow/pull/69450#discussion_r3527950349
##########
providers/snowflake/tests/unit/snowflake/operators/test_snowflake.py:
##########
@@ -359,6 +359,49 @@ def test_poll_on_queries_raises_runtime_error_on_status_check_failure(
with pytest.raises(RuntimeError, match="Failed to get status for query uuid1"):
operator.poll_on_queries()
+ def test_poll_on_queries_no_sleep_when_all_resolved(
+ self, mock_execute_query, mock_get_sql_api_query_status
+ ):
Review Comment:
Since `poll_on_queries()` is called directly and we set `operator.query_ids` in the test , so `mock_execute_query` never fires — it can be dropped from the signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix SnowflakeSqlApiOperator polling to avoid needless sleeps [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #69450:
URL: https://github.com/apache/airflow/pull/69450#discussion_r3528842396
##########
providers/snowflake/tests/unit/snowflake/operators/test_snowflake.py:
##########
@@ -359,6 +359,49 @@ def test_poll_on_queries_raises_runtime_error_on_status_check_failure(
with pytest.raises(RuntimeError, match="Failed to get status for query uuid1"):
operator.poll_on_queries()
+ def test_poll_on_queries_no_sleep_when_all_resolved(
+ self, mock_execute_query, mock_get_sql_api_query_status
+ ):
+ operator = SnowflakeSqlApiOperator(
+ task_id=TASK_ID,
+ snowflake_conn_id="snowflake_default",
+ sql=SQL_MULTIPLE_STMTS,
+ statement_count=4,
+ do_xcom_push=False,
+ )
+ operator.query_ids = ["uuid1", "uuid2"]
+ mock_get_sql_api_query_status.side_effect = [{"status": "success"}, {"status": "error"}]
+
+ with mock.patch("time.sleep") as mock_sleep:
+ result = operator.poll_on_queries()
+
+ mock_sleep.assert_not_called()
+ assert result["success"] == {"uuid1": {"status": "success"}}
+ assert result["error"] == {"uuid2": {"status": "error"}}
+ assert result["running"] == {}
+
+ def test_poll_on_queries_sleeps_once_per_cycle(self, mock_execute_query, mock_get_sql_api_query_status):
Review Comment:
Handled in 7b43a636bb
##########
providers/snowflake/tests/unit/snowflake/operators/test_snowflake.py:
##########
@@ -359,6 +359,49 @@ def test_poll_on_queries_raises_runtime_error_on_status_check_failure(
with pytest.raises(RuntimeError, match="Failed to get status for query uuid1"):
operator.poll_on_queries()
+ def test_poll_on_queries_no_sleep_when_all_resolved(
+ self, mock_execute_query, mock_get_sql_api_query_status
+ ):
Review Comment:
Handled in 7b43a636bb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org