You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/23 00:17:30 UTC
[GitHub] [incubator-pekko-grpc] pjfanning opened a new pull request, #70: more pekko naming changes
pjfanning opened a new pull request, #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70
relates to #23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201864841
##########
README.md:
##########
@@ -50,10 +50,6 @@ The project is split up in a number of subprojects:
Additionally, 'plugin-tester-java' and 'plugin-tester-scala' contain an example
project in Java and Scala respectively, with both sbt and Gradle configurations.
-## Compatibility & support
-
-If used with JDK 8 prior to version 1.8.0_251 you must add an [ALPN agent](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-).
Review Comment:
I've added this back but highlight the link is an Akka link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #70: more pekko naming changes
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201913626
##########
README.md:
##########
@@ -50,10 +50,6 @@ The project is split up in a number of subprojects:
Additionally, 'plugin-tester-java' and 'plugin-tester-scala' contain an example
project in Java and Scala respectively, with both sbt and Gradle configurations.
-## Compatibility & support
-
-If used with JDK 8 prior to version 1.8.0_251 you must add an [ALPN agent](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-).
Review Comment:
Okay fine, I won't die on this hill. Will approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #70: more pekko naming changes
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201838383
##########
README.md:
##########
@@ -50,10 +50,6 @@ The project is split up in a number of subprojects:
Additionally, 'plugin-tester-java' and 'plugin-tester-scala' contain an example
project in Java and Scala respectively, with both sbt and Gradle configurations.
-## Compatibility & support
-
-If used with JDK 8 prior to version 1.8.0_251 you must add an [ALPN agent](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-).
Review Comment:
Rather than removing it can we instead just comment that you need to use JDK 8 1.8.0_251 or later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #70: more pekko naming changes
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201836749
##########
docs/src/main/paradox/client/index.md:
##########
@@ -1,6 +1,6 @@
# Consuming Services (Client)
-Get our Quickstart project (available for [Scala](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-scala) and [Java](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-java)) to get started quickly.
+See the Akka gRPC Quickstart project (available for [Scala](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-scala) and [Java](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-java)) to get started quickly.
Review Comment:
Fair enough, I guess we can always update this later when we migrate the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning merged pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201726483
##########
docs/src/main/paradox/client/index.md:
##########
@@ -1,6 +1,6 @@
# Consuming Services (Client)
-Get our Quickstart project (available for [Scala](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-scala) and [Java](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-java)) to get started quickly.
+See the Akka gRPC Quickstart project (available for [Scala](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-scala) and [Java](https://developer.lightbend.com/start/?group=akka&project=akka-grpc-quickstart-java)) to get started quickly.
Review Comment:
we haven't migrated these quickstart projects yet - so seems best to admit that the Akka one is useful as a guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #70: more pekko naming changes
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#issuecomment-1558852262
>
Good to know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #70: more pekko naming changes
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201867504
##########
README.md:
##########
@@ -50,10 +50,6 @@ The project is split up in a number of subprojects:
Additionally, 'plugin-tester-java' and 'plugin-tester-scala' contain an example
project in Java and Scala respectively, with both sbt and Gradle configurations.
-## Compatibility & support
-
-If used with JDK 8 prior to version 1.8.0_251 you must add an [ALPN agent](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-).
Review Comment:
I have a preference for JDK 8 1.8.0_251 or later because I don't want to encourage people using older JDK's and as a bonus we don't need to link to any Akka docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201912648
##########
README.md:
##########
@@ -50,10 +50,6 @@ The project is split up in a number of subprojects:
Additionally, 'plugin-tester-java' and 'plugin-tester-scala' contain an example
project in Java and Scala respectively, with both sbt and Gradle configurations.
-## Compatibility & support
-
-If used with JDK 8 prior to version 1.8.0_251 you must add an [ALPN agent](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-).
Review Comment:
this same stuff is basically in the paradox docs - I'd prefer to keep them consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#issuecomment-1558850832
> > there are comms issues with the link validator job (the CI job keeps failing when trying to download code from Coursier)
>
> I noticed these issues in general when downloading Pekko snapshot artifacts. It seems that that we are putting too much pressure on Apache Snapshots repo and in some cases the snapshots fail to download.
`curl -fLo cs https://git.io/coursier-cli-linux` is today's problem - this has been flaky for months though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#discussion_r1201724001
##########
README.md:
##########
@@ -50,10 +50,6 @@ The project is split up in a number of subprojects:
Additionally, 'plugin-tester-java' and 'plugin-tester-scala' contain an example
project in Java and Scala respectively, with both sbt and Gradle configurations.
-## Compatibility & support
-
-If used with JDK 8 prior to version 1.8.0_251 you must add an [ALPN agent](https://doc.akka.io/docs/akka-http/10.1/server-side/http2.html#application-layer-protocol-negotiation-alpn-).
Review Comment:
the link does not work with Pekko docs because that subsection was removed from Akka docs before we forked - seems tidiest just to remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #70: more pekko naming changes
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#issuecomment-1558730764
there are comms issues with the link validator job (the CI job keeps failing when trying to download code from Coursier)
I can double check the link validator job another day but would like to get this merged as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #70: more pekko naming changes
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #70:
URL: https://github.com/apache/incubator-pekko-grpc/pull/70#issuecomment-1558839877
> there are comms issues with the link validator job (the CI job keeps failing when trying to download code from Coursier)
I noticed these issues in general when downloading Pekko snapshot artifacts. It seems that that we are putting too much pressure on Apache Snapshots repo and in some cases the snapshots fail to download.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org