[GitHub] [singa] XJDKC edited a comment on pull request #697: New Model Layer Operator API

[GitBox <gi...@apache.org>]

XJDKC edited a comment on pull request #697:
URL: https://github.com/apache/singa/pull/697#issuecomment-636885818


   > As discussed, last commit changes: 1 Restore creator settings for interim tensors; 2 update device_check() after new get states implementation; 3 fix typo in LSTM; 4 fix test case for save model and load model, as new impl does not keep top level layer name; 5 remove proof of concept script.
   > Retested test_model.py, test_operations.py.
   > From my side, it looks ok to go except memory issue to be fix.
   
   Thanks, @dcslin. 
   * For 4, It's because the DoubleLinear in the test case does not meet specifications. Change \_\_call\_\_ to forward will solve this problem, I will update it.
   * I have checked the models in examples, now they can be trained correctly.
   * Since the merge resulted in many duplicate commits, I will clean it up by rebasing the branch.
   * I will remove converter.py, lsgan.py, vanilla.py
   * I will fix examples/mlp/module.py
   
   Hi, @joddiy. pls help to fix these linting errors. https://travis-ci.org/github/apache/singa/jobs/693422214#L2361


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org