svn commit: r1659956 - in /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos: COSFloat.java COSInteger.java

[ms...@apache.org]

Author: msahyoun
Date: Sun Feb 15 17:48:48 2015
New Revision: 1659956

URL: http://svn.apache.org/r1659956
Log:
PDFBOX-2685 remove setValue() as COS primitives shall be immutable

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInteger.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java?rev=1659956&r1=1659955&r2=1659956&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSFloat.java Sun Feb 15 17:48:48 2015
@@ -38,7 +38,10 @@ public class COSFloat extends COSNumber
      */
     public COSFloat( float aFloat )
     {
-        setValue(aFloat);
+        // use a BigDecimal as intermediate state to avoid 
+        // a floating point string representation of the float value
+        value = new BigDecimal(String.valueOf(aFloat));
+        valueAsString = removeNullDigits(value.toPlainString());
     }
 
     /**
@@ -61,19 +64,6 @@ public class COSFloat extends COSNumber
         }
     }
 
-    /**
-     * Set the value of the float object.
-     *
-     * @param floatValue The new float value.
-     */
-    public final void setValue( float floatValue )
-    {
-        // use a BigDecimal as intermediate state to avoid 
-        // a floating point string representation of the float value
-        value = new BigDecimal(String.valueOf(floatValue));
-        valueAsString = removeNullDigits(value.toPlainString());
-    }
-
     private String removeNullDigits(String value)
     {
         // remove fraction digit "0" only

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInteger.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInteger.java?rev=1659956&r1=1659955&r2=1659956&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInteger.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSInteger.java Sun Feb 15 17:48:48 2015
@@ -133,16 +133,6 @@ public class COSInteger extends COSNumbe
     }
 
     /**
-     * Change the value of this reference.
-     *
-     * @param newValue The new value.
-     */
-    public void setValue( long newValue )
-    {
-        value = newValue;
-    }
-
-    /**
      * polymorphic access to value as float.
      *
      * @return The float value of this object.