You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/15 18:03:30 UTC

[GitHub] [tvm] tkonolige commented on a change in pull request #7287: [PRNG] Add check to PRNG to make sure that unsigned integer arithmetic is wrapping

tkonolige commented on a change in pull request #7287:
URL: https://github.com/apache/tvm/pull/7287#discussion_r558479119



##########
File path: python/tvm/topi/random/kernel.py
##########
@@ -20,6 +20,8 @@
 from ... import tir
 from ...tir import ir_builder
 
+import numpy as np

Review comment:
       I want people to be able to run this function themselves to check if their platform is supported. If I put it in the test file, you can't import and use it. You'd have to edit the test manually to include your platform.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org