[GitHub] [iceberg] reswqa commented on a diff in pull request #7906: Dell: Migrate tests in dell to junit5

["reswqa (via GitHub)" <gi...@apache.org>]

reswqa commented on code in PR #7906:
URL: https://github.com/apache/iceberg/pull/7906#discussion_r1241063700


##########
common/src/main/java/org/apache/iceberg/common/testutils/CustomExtension.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.common.testutils;
+
+import org.junit.jupiter.api.extension.ExtensionContext;
+
+/**
+ * An extension that is invoked before/after all/each tests, depending on whether it is wrapped in a
+ * {@link PerTestCallbackWrapper} or {@link PerClassCallbackWrapper}.
+ *
+ * <p>{@code before} method will be called in {@code beforeEach} or {@code beforeAll}. {@code after}
+ * will be called in {@code afterEach} or {@code afterAll}.
+ *
+ * <p>Usage example:
+ *
+ * <pre><code>
+ * public class Test{
+ *      {@literal @}RegisterExtension
+ *      static PerClassCallbackWrapper classCallbackWrapper = new PerClassCallbackWrapper(customExtension);
+ *      {@literal @}RegisterExtension
+ *      PerTestCallbackWrapper testCallbackWrapper = new PerTestCallbackWrapper(customExtension);
+ * }
+ * }</code></pre>
+ */
+public interface CustomExtension {

Review Comment:
   I'm not sure witch module these test utils should be placed as not familiar with the code base.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org