You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 15:02:48 UTC

[GitHub] [airflow] josh-fell commented on a diff in pull request #25761: Migrate Google example gcp_transfer to new design AIP-47

josh-fell commented on code in PR #25761:
URL: https://github.com/apache/airflow/pull/25761#discussion_r948060016


##########
tests/system/providers/google/cloud/transfers/example_cloud_storage_transfer_service_gcp.py:
##########
@@ -142,13 +145,28 @@
         task_id="delete_transfer_from_gcp_job",
         job_name="{{task_instance.xcom_pull('create_transfer')['name']}}",
         project_id=GCP_PROJECT_ID,
+        trigger_rule=TriggerRule.ALL_DONE,
     )
 
-    chain(

Review Comment:
   Just curious why not keep `chain()` here? You can still add the comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org