You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2009/09/14 19:25:07 UTC
svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Author: trawick
Date: Mon Sep 14 17:25:07 2009
New Revision: 814743
URL: http://svn.apache.org/viewvc?rev=814743&view=rev
Log:
promote, demote
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?rev=814743&r1=814742&r2=814743&view=diff
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Mon Sep 14 17:25:07 2009
@@ -89,6 +89,15 @@
PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
[ start all new proposals below, under PATCHES PROPOSED. ]
+ * ab: Add support for HTTP PUT to ab.
+ Trunk Patch: http://svn.apache.org/viewvc?rev=811806&view=rev
+ http://svn.apache.org/viewvc?rev=811869&view=rev
+ 2.2.x Patch: http://people.apache.org/~minfrin/ab.diff
+ +1: minfrin, covener, poirier
+
+ * htcacheclean: 19 ways to fail, 1 error message. Fixed.
+ Trunk Patch: http://svn.apache.org/viewvc?view=rev&revision=814091
+ +1: minfrin, covener, poirier
PATCHES PROPOSED TO BACKPORT FROM TRUNK:
[ New proposals should be added at the end of the list ]
@@ -115,12 +124,6 @@
2.2.x Patch: http://people.apache.org/~minfrin/ssl_engine_pphrase.diff
+1: minfrin
- * ab: Add support for HTTP PUT to ab.
- Trunk Patch: http://svn.apache.org/viewvc?rev=811806&view=rev
- http://svn.apache.org/viewvc?rev=811869&view=rev
- 2.2.x Patch: http://people.apache.org/~minfrin/ab.diff
- +1: minfrin, covener, poirier
-
* mod_ssl: Improve environment variable extraction to be more
efficient and to correctly handle DNs with duplicate tags.
PR 45975.
@@ -134,10 +137,8 @@
Trunk patch: http://svn.apache.org/viewvc?view=rev&revision=797563
2.2.x patch: http://people.apache.org/~poirier/patch-2.2.x-PR30586.txt
+1: poirier, minfrin
-
- * htcacheclean: 19 ways to fail, 1 error message. Fixed.
- Trunk Patch: http://svn.apache.org/viewvc?view=rev&revision=814091
- +1: minfrin, covener, poirier
+ -1: trawick (Memory use for dumping the database is now unbounded; it
+ doesn't even look difficult to avoid allocating/copying.)
* mod_ldap: hints in usage for LDAPCacheEntries and LDAPOpCacheEntries
updated to match manual and code (0 or -1 to disable)
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Dan Poirier <po...@pobox.com>.
Dan Poirier <po...@pobox.com> writes:
> Can you elaborate? I don't see how these changes create additional
> and unbounded memory usage.
Sorry, I was confused and thought the comment applied to another, more
innocuous proposed backport. I'll go look at this again.
--
Dan Poirier <po...@pobox.com>
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On Mon, Sep 14, 2009 at 1:59 PM, Dan Poirier <po...@pobox.com> wrote:
> On 09/14/2009 01:25 PM, trawick@apache.org wrote:
>
>> - * htcacheclean: 19 ways to fail, 1 error message. Fixed.
>> - Trunk Patch: http://svn.apache.org/viewvc?view=rev&revision=814091
>> - +1: minfrin, covener, poirier
>> + -1: trawick (Memory use for dumping the database is now unbounded; it
>> + doesn't even look difficult to avoid allocating/copying.)
>>
>>
> Can you elaborate? I don't see how these changes create additional and
> unbounded memory usage.
>
>
Look at htdbm_list().
Without the patch, there is exactly one memory allocation (for
HUGE_STRING_LEN bytes) regardless of how many records are in the database.
After the patch, there are two memory allocations for every record in the
database.
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Dan Poirier <po...@pobox.com>.
On 09/14/2009 01:25 PM, trawick@apache.org wrote:
> - * htcacheclean: 19 ways to fail, 1 error message. Fixed.
> - Trunk Patch: http://svn.apache.org/viewvc?view=rev&revision=814091
> - +1: minfrin, covener, poirier
> + -1: trawick (Memory use for dumping the database is now unbounded; it
> + doesn't even look difficult to avoid allocating/copying.)
>
Can you elaborate? I don't see how these changes create additional and
unbounded memory usage.
Dan Poirier
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On Mon, Sep 14, 2009 at 1:35 PM, Graham Leggett <mi...@sharp.fm> wrote:
> trawick@apache.org wrote:
>
> > Author: trawick
> > Date: Mon Sep 14 17:25:07 2009
> > New Revision: 814743
> >
> > URL: http://svn.apache.org/viewvc?rev=814743&view=rev
> > Log:
> > promote, demote
>
> With everything moved around, I am assuming you are referring to this:
>
> * htdbm: Avoid buffer overflows.
> PR: 30586
> Trunk patch: http://svn.apache.org/viewvc?view=rev&revision=797563
> 2.2.x patch: http://people.apache.org/~poirier/patch-2.2.x-PR30586.txt<http://people.apache.org/%7Epoirier/patch-2.2.x-PR30586.txt>
> +1: poirier, minfrin
> -1: trawick (Memory use for dumping the database is now unbounded; it
> doesn't even look difficult to avoid allocating/copying.)
>
> Can you be more specific?
>
For each key in the database*: allocate memory from a pool, without
releasing the pool memory
*unbounded
I followed up to the original commit with suggested fixes.
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Graham Leggett <mi...@sharp.fm>.
Ruediger Pluem wrote:
>> * htdbm: Avoid buffer overflows.
>> PR: 30586
>> Trunk patch: http://svn.apache.org/viewvc?view=rev&revision=797563
>> 2.2.x patch: http://people.apache.org/~poirier/patch-2.2.x-PR30586.txt
>> +1: poirier, minfrin
>> -1: trawick (Memory use for dumping the database is now unbounded; it
>> doesn't even look difficult to avoid allocating/copying.)
>>
>> Can you be more specific?
>
> Plus I guess you should also raise a veto on the trunk revision r797563.
Jeff just did, I can't see how patch-2.2.x-PR30586.txt could be vetoed
and not 797563. :)
Regards,
Graham
--
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On Mon, Sep 14, 2009 at 3:12 PM, Ruediger Pluem <rp...@apache.org> wrote:
>
>
> On 09/14/2009 07:35 PM, Graham Leggett wrote:
> > trawick@apache.org wrote:
> >
> >> Author: trawick
> >> Date: Mon Sep 14 17:25:07 2009
> >> New Revision: 814743
> >>
> >> URL: http://svn.apache.org/viewvc?rev=814743&view=rev
> >> Log:
> >> promote, demote
> >
> > With everything moved around, I am assuming you are referring to this:
> >
> > * htdbm: Avoid buffer overflows.
> > PR: 30586
> > Trunk patch: http://svn.apache.org/viewvc?view=rev&revision=797563
> > 2.2.x patch:
> http://people.apache.org/~poirier/patch-2.2.x-PR30586.txt<http://people.apache.org/%7Epoirier/patch-2.2.x-PR30586.txt>
> > +1: poirier, minfrin
> > -1: trawick (Memory use for dumping the database is now unbounded; it
> > doesn't even look difficult to avoid allocating/copying.)
> >
> > Can you be more specific?
>
> Plus I guess you should also raise a veto on the trunk revision r797563.
>
Perhaps I'm not the only one getting mail out of order today ;)
(I did follow up to the trunk commit and expand further on my 2.2.x/STATUS
comment, though that response didn't use the magic strings "-1" or "veto".)
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Ruediger Pluem <rp...@apache.org>.
On 09/14/2009 07:35 PM, Graham Leggett wrote:
> trawick@apache.org wrote:
>
>> Author: trawick
>> Date: Mon Sep 14 17:25:07 2009
>> New Revision: 814743
>>
>> URL: http://svn.apache.org/viewvc?rev=814743&view=rev
>> Log:
>> promote, demote
>
> With everything moved around, I am assuming you are referring to this:
>
> * htdbm: Avoid buffer overflows.
> PR: 30586
> Trunk patch: http://svn.apache.org/viewvc?view=rev&revision=797563
> 2.2.x patch: http://people.apache.org/~poirier/patch-2.2.x-PR30586.txt
> +1: poirier, minfrin
> -1: trawick (Memory use for dumping the database is now unbounded; it
> doesn't even look difficult to avoid allocating/copying.)
>
> Can you be more specific?
Plus I guess you should also raise a veto on the trunk revision r797563.
Regards
Rüdiger
Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Graham Leggett <mi...@sharp.fm>.
trawick@apache.org wrote:
> Author: trawick
> Date: Mon Sep 14 17:25:07 2009
> New Revision: 814743
>
> URL: http://svn.apache.org/viewvc?rev=814743&view=rev
> Log:
> promote, demote
With everything moved around, I am assuming you are referring to this:
* htdbm: Avoid buffer overflows.
PR: 30586
Trunk patch: http://svn.apache.org/viewvc?view=rev&revision=797563
2.2.x patch: http://people.apache.org/~poirier/patch-2.2.x-PR30586.txt
+1: poirier, minfrin
-1: trawick (Memory use for dumping the database is now unbounded; it
doesn't even look difficult to avoid allocating/copying.)
Can you be more specific?
Regards,
Graham
--