You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2023/02/02 20:20:44 UTC

[GitHub] [airflow] eladkal commented on a diff in pull request #29341: Add clarification about AWS Connection behaviour

eladkal commented on code in PR #29341:
URL: https://github.com/apache/airflow/pull/29341#discussion_r1095044908


##########
docs/apache-airflow-providers-amazon/connections/aws.rst:
##########
@@ -20,8 +20,21 @@
 Amazon Web Services Connection
 ==============================
 
-The Amazon Web Services connection type enables the :ref:`AWS Integrations
-<AWS>`.
+The Amazon Web Services connection type enables the :ref:`AWS Integrations <AWS>`.
+
+.. important:: Amazon Web Services Connection could be tested in the UI/API or by call
+    :meth:`~airflow.providers.amazon.aws.hooks.base_aws.AwsGenericHook.test_connection`,
+    it is **important** to correct interpret result of this test.
+    During this test components of Amazon Provider invoke AWS Security Token Service API
+    `GetCallerIdentity <https://docs.aws.amazon.com/STS/latest/APIReference/API_GetCallerIdentity.html>`__.
+    This service **only** could check is your credentials valid or not.

Review Comment:
   ```suggestion
       This service can  **only** check if your credentials are valid.
   ```



##########
docs/apache-airflow-providers-amazon/connections/aws.rst:
##########
@@ -20,8 +20,21 @@
 Amazon Web Services Connection
 ==============================
 
-The Amazon Web Services connection type enables the :ref:`AWS Integrations
-<AWS>`.
+The Amazon Web Services connection type enables the :ref:`AWS Integrations <AWS>`.
+
+.. important:: Amazon Web Services Connection could be tested in the UI/API or by call
+    :meth:`~airflow.providers.amazon.aws.hooks.base_aws.AwsGenericHook.test_connection`,
+    it is **important** to correct interpret result of this test.
+    During this test components of Amazon Provider invoke AWS Security Token Service API
+    `GetCallerIdentity <https://docs.aws.amazon.com/STS/latest/APIReference/API_GetCallerIdentity.html>`__.
+    This service **only** could check is your credentials valid or not.
+    Unfortunately it is not possible to validate is this credentials has access to specific AWS service or not.

Review Comment:
   ```suggestion
       Unfortunately it is not possible to validate if credentials have access to specific AWS service or not.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org