You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/26 15:33:03 UTC

[GitHub] [iotdb] liuminghui233 opened a new pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

liuminghui233 opened a new pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234


   After merge #4134, the parsing performance of SQL has dropped significantly. 
   
   > ANTLR can use two different prediction modes: SLL and LL*. They are also known as parsing strategies. Basically, these dictate how much effort the parser will put to parse the input. The first one is simpler and quicker, the second one is more powerful but a bit slower. By more powerful we mean that it can parse more complicated inputs that would result as ambiguous using just the first strategy.
   
   Due to some modifications in #4134, SLL cannot parse the grammar correctly. The parser had to switch to LL mode, wasting a lot of performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 edited a comment on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 edited a comment on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can experiment with the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can conduct tests on the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-955632894


   @SteveYurongSu Hi, I did some experiments. The performance of SQL parsing is approximately unchanged (perhaps slightly improved) compared with before rewrite.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 edited a comment on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 edited a comment on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can experiment with the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-957073572


   @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit? 
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-957073572


   @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit? 
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
cornmonster commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-957073572


   @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit? 
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JackieTien97 merged pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can conduct tests on the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can conduct tests on the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] liuminghui233 edited a comment on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
liuminghui233 edited a comment on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-958598635


   > @liuminghui233 Hi, I have some changes on the ANTLR part. And I am wondering about the way you find the causes of the performance issue. Could you explain a little bit?
   > 
   > Thanks!
   
   Hi, you can refer to this [blog](https://tomassetti.me/improving-the-performance-of-an-antlr-parser) to learn more about the performance of Antlr4. Before merging your PR, you can experiment with the parsing performance of some critical statements (such as insert and query statements). Good luck!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-952109054


   
   [![Coverage Status](https://coveralls.io/builds/43784381/badge)](https://coveralls.io/builds/43784381)
   
   Coverage increased (+0.002%) to 66.923% when pulling **c34069db56bf6b92739ca4030362e9b9c896d114 on liuminghui233:antlr_performance_debug** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-952109054


   
   [![Coverage Status](https://coveralls.io/builds/43798962/badge)](https://coveralls.io/builds/43798962)
   
   Coverage increased (+0.1%) to 67.044% when pulling **7c9a2d1e37da60e5b78a1bc6ef2e920bc48075e8 on liuminghui233:antlr_performance_debug** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4234: [IOTDB-1280] Solve the performance reduction caused by syntax error in SLL prediction mode

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4234:
URL: https://github.com/apache/iotdb/pull/4234#issuecomment-952109054


   
   [![Coverage Status](https://coveralls.io/builds/43870112/badge)](https://coveralls.io/builds/43870112)
   
   Coverage increased (+0.01%) to 66.908% when pulling **c54ac0576cd13c8aa60b81cfbe7b81939c7a16f8 on liuminghui233:antlr_performance_debug** into **b5ef4d8bb5e1082ff55345cdb5e728fd1a7c2fc9 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org