You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/01/25 05:40:47 UTC

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18171


Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................

[clock] add 'unsafe' tag for --use_hybrid_clock

Adding the 'unsafe' tag to the hidden --use_hybrid_clock flag makes
it impossible to start a Kudu server with --use_hybrid_clock=false
unless --unlock_unsafe_flags is specified.  This is to discourage
using LogicalClock implementation instead of HybridClock implementation
in regular (i.e. non-test) environments.

This is a follow-up to 96a6a8b91bd069ed5ebe3dfd4eb8179708eacda9.

Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18171/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18171

to look at the new patch set (#3).

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................

[clock] add 'unsafe' tag for --use_hybrid_clock

Adding the 'unsafe' tag to the hidden --use_hybrid_clock flag makes
it impossible to start a Kudu server with --use_hybrid_clock=false
unless --unlock_unsafe_flags is specified.  This is to discourage
using LogicalClock implementation instead of HybridClock implementation
in regular (i.e. non-test) environments.

This is a follow-up to 96a6a8b91bd069ed5ebe3dfd4eb8179708eacda9.

Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 7 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18171/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18171/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

http://gerrit.cloudera.org:8080/#/c/18171/1/src/kudu/clock/hybrid_clock.cc@78
PS1, Line 78: It's highly discouraged setting this flag 'false' "
            :             "in any production-grade deployment since that could introduce "
            : 
nit: how about "Setting this flag to 'false' is highly discouraged in any production-grade deployment, as it can introduce extensive latency and surprising behavior."



-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 07:25:16 +0000
Gerrit-HasComments: Yes

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18171/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

http://gerrit.cloudera.org:8080/#/c/18171/1/src/kudu/clock/hybrid_clock.cc@78
PS1, Line 78: It's highly discouraged setting this flag 'false' "
            :             "in any production-grade deployment since that could introduce "
            : 
> nit: how about "Setting this flag to 'false' is highly discouraged in any p
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 07:30:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................

[clock] add 'unsafe' tag for --use_hybrid_clock

Adding the 'unsafe' tag to the hidden --use_hybrid_clock flag makes
it impossible to start a Kudu server with --use_hybrid_clock=false
unless --unlock_unsafe_flags is specified.  This is to discourage
using LogicalClock implementation instead of HybridClock implementation
in regular (i.e. non-test) environments.

This is a follow-up to 96a6a8b91bd069ed5ebe3dfd4eb8179708eacda9.

Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Reviewed-on: http://gerrit.cloudera.org:8080/18171
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  Attila Bukor: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 3: Verified+1

unrelated test failure in AdminCliTest.TestAddAndDropRangePartition


-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 22:24:47 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc@80
PS2, Line 80:             "introduce extensive latency and surprising behavior. "
> Does surprising behavior mean/include voiding consistency guarantees? If it
Done


http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc@80
PS2, Line 80:             "introduce extensive latency and surprising behavior. "
> +1
Right: that's about not supporting commit-wait consistency mode at least.



-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 21:45:51 +0000
Gerrit-HasComments: Yes

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc@80
PS2, Line 80:             "introduce extensive latency and surprising behavior. "
Does surprising behavior mean/include voiding consistency guarantees? If it does, maybe call it out explicitly?



-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 12:36:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 21:47:11 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

http://gerrit.cloudera.org:8080/#/c/18171/2/src/kudu/clock/hybrid_clock.cc@80
PS2, Line 80:             "introduce extensive latency and surprising behavior. "
> Does surprising behavior mean/include voiding consistency guarantees? If it
+1



-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 19:10:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18171

to look at the new patch set (#2).

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................

[clock] add 'unsafe' tag for --use_hybrid_clock

Adding the 'unsafe' tag to the hidden --use_hybrid_clock flag makes
it impossible to start a Kudu server with --use_hybrid_clock=false
unless --unlock_unsafe_flags is specified.  This is to discourage
using LogicalClock implementation instead of HybridClock implementation
in regular (i.e. non-test) environments.

This is a follow-up to 96a6a8b91bd069ed5ebe3dfd4eb8179708eacda9.

Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18171/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18171 )

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Patch Set 1: Verified+1

unrelated test failure in DisableWriteWhenExceedingQuotaTest.TestDisableWritePrivilegeWhenExceedingSizeQuota


-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 25 Jan 2022 06:27:05 +0000
Gerrit-HasComments: No

[kudu-CR] [clock] add 'unsafe' tag for --use hybrid clock

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [clock] add 'unsafe' tag for --use_hybrid_clock
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I46579c071697ddcee808a708677364be6e7a4a19
Gerrit-Change-Number: 18171
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)