You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/18 13:43:54 UTC
[GitHub] [rocketmq] 9526xu opened a new pull request #1867: fix transaction
message doc #1866
9526xu opened a new pull request #1867: fix transaction message doc #1866
URL: https://github.com/apache/rocketmq/pull/1867
## What is the purpose of the change
docs-cn and doc-en hash some error in transaction message.
## Brief changelog
fix doc in :
`AbstractTransactionCheckListener`---->`AbstractTransactionalMessageCheckListener`
`transactionMsgTimeout`------>`transactionTimeout`
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1867: fix transaction
message doc #1866
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1867: fix transaction message doc #1866
URL: https://github.com/apache/rocketmq/pull/1867#issuecomment-600650836
[](https://coveralls.io/builds/29445833)
Coverage increased (+0.1%) to 50.968% when pulling **bebb4a86da3cdb99aee4e052fc39c923b5a2eb81 on 9526xu:fix-transaction-doc** into **8ef01a6c635f6972847c40d5540b1945180d7cbd on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin commented on issue #1867: [ISSUE #1866] Fix
transaction message doc
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #1867: [ISSUE #1866] Fix transaction message doc
URL: https://github.com/apache/rocketmq/pull/1867#issuecomment-602677059
Please change the target branch to develop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] RongtongJin merged pull request #1867: [ISSUE #1866] Fix
transaction message doc
Posted by GitBox <gi...@apache.org>.
RongtongJin merged pull request #1867: [ISSUE #1866] Fix transaction message doc
URL: https://github.com/apache/rocketmq/pull/1867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] 9526xu commented on issue #1867: [ISSUE #1866] Fix
transaction message doc
Posted by GitBox <gi...@apache.org>.
9526xu commented on issue #1867: [ISSUE #1866] Fix transaction message doc
URL: https://github.com/apache/rocketmq/pull/1867#issuecomment-602678856
> Please change the target branch to develop.
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services